From 72e02c73b64f1ff56b2d53ec63d68486a4f1ff90 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 17 Dec 2012 15:31:21 +0100 Subject: s3-rpc_server: Fix a possible null pointer dereference. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This variable can be set to NULL in an earlier function call. Found by Coverity. Signed-off-by: Andreas Schneider Reviewed-by: Günther Deschner --- source3/rpc_server/spoolss/srv_spoolss_nt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index b8ee9f4072..531b2898ab 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -4428,7 +4428,8 @@ static WERROR enum_all_printers_info_1_name(TALLOC_CTX *mem_ctx, DEBUG(4,("enum_all_printers_info_1_name\n")); - if ((servername[0] == '\\') && (servername[1] == '\\')) { + if (servername != NULL && + (servername[0] == '\\') && (servername[1] == '\\')) { s = servername + 2; } -- cgit