From 7ade7f947b37b8da2f4f29d0981a7e6128ca66f4 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 8 Aug 2006 17:34:51 +0000 Subject: r17461: Ensure we never save a NULL SID mapping. || should be &&. Found by Whitfield school. Jeremy. (This used to be commit f8584a475853bd8937fb0cf1b304c98f96fbd872) --- source3/nsswitch/winbindd_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/nsswitch/winbindd_cache.c b/source3/nsswitch/winbindd_cache.c index 95a66420c5..42206de055 100644 --- a/source3/nsswitch/winbindd_cache.c +++ b/source3/nsswitch/winbindd_cache.c @@ -1241,7 +1241,7 @@ do_query: status = domain->backend->name_to_sid(domain, mem_ctx, domain_name, name, sid, type); /* and save it */ - if (domain->online || !is_null_sid(sid)) { + if (domain->online && !is_null_sid(sid)) { wcache_save_name_to_sid(domain, status, domain_name, name, sid, *type); } -- cgit