From 7ca399c0755e186508a4ed9796cbbbe6f50181e9 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Wed, 14 Feb 2007 21:55:29 +0000 Subject: r21351: Change ldb ejs bindings return codes. We were returning just true/false and discarding error number and string. This checking probably breaks swat, will fix it in next round as swat is what made me look into this as I had no way to get back error messages to show to the users. Simo. (This used to be commit 35886b4ae68be475b0fc8b2689ca04d766661261) --- source4/scripting/ejs/mprutil.c | 31 +- source4/scripting/ejs/smbcalls.h | 1 + source4/scripting/ejs/smbcalls_ldb.c | 10 +- source4/scripting/libjs/provision.js | 113 ++-- source4/setup/setpassword | 13 +- testprogs/ejs/ldap.js | 372 ++++++------ testprogs/ejs/ldb.js | 202 +++---- testprogs/ejs/minschema.js | 54 +- testprogs/ejs/samba3sam.js | 1035 +++++++++++++++++----------------- 9 files changed, 945 insertions(+), 886 deletions(-) diff --git a/source4/scripting/ejs/mprutil.c b/source4/scripting/ejs/mprutil.c index cfed69dbe0..459f198dca 100644 --- a/source4/scripting/ejs/mprutil.c +++ b/source4/scripting/ejs/mprutil.c @@ -223,19 +223,32 @@ failed: /* - turn an array of ldb_messages into a ejs object variable + build a MprVar result object for ldb operations with lots of funky properties */ -struct MprVar mprLdbArray(struct ldb_context *ldb, - struct ldb_message **msg, int count, const char *name) +struct MprVar mprLdbResult(struct ldb_context *ldb, int err, struct ldb_result *result) { - struct MprVar res; - int i; + struct MprVar ret; + struct MprVar ary; + + ret = mprObject("ldbret"); + + mprSetVar(&ret, "error", mprCreateIntegerVar(err)); + mprSetVar(&ret, "errstr", mprString(ldb_errstring(ldb))); + + ary = mprArray("ldb_message"); + if (result) { + int i; - res = mprArray(name); - for (i=0;icount; i++) { + mprAddArray(&ary, i, mprLdbMessage(ldb, result->msgs[i])); + } } - return res; + + mprSetVar(&ret, "msgs", ary); + + /* TODO: add referrals, exteded ops, and controls */ + + return ret; } diff --git a/source4/scripting/ejs/smbcalls.h b/source4/scripting/ejs/smbcalls.h index 9fa9100276..a525403493 100644 --- a/source4/scripting/ejs/smbcalls.h +++ b/source4/scripting/ejs/smbcalls.h @@ -21,6 +21,7 @@ */ #include "lib/appweb/ejs/ejs.h" +#include "lib/ldb/include/ldb.h" void mpr_Return(int eid, struct MprVar); NTSTATUS mprSetVar(struct MprVar *v, const char *name, struct MprVar val); diff --git a/source4/scripting/ejs/smbcalls_ldb.c b/source4/scripting/ejs/smbcalls_ldb.c index 3c368bba4f..fc44862985 100644 --- a/source4/scripting/ejs/smbcalls_ldb.c +++ b/source4/scripting/ejs/smbcalls_ldb.c @@ -108,9 +108,9 @@ static int ejs_ldbSearch(MprVarHandle eid, int argc, struct MprVar **argv) ret = ldb_search(ldb, basedn, scope, expression, attrs, &res); if (ret != LDB_SUCCESS) { ejsSetErrorMsg(eid, "ldb.search failed - %s", ldb_errstring(ldb)); - mpr_Return(eid, mprCreateUndefinedVar()); + mpr_Return(eid, mprLdbResult(ldb, ret, NULL)); } else { - mpr_Return(eid, mprLdbArray(ldb, res->msgs, res->count, "ldb_message")); + mpr_Return(eid, mprLdbResult(ldb, ret, res)); talloc_free(res); } talloc_free(tmp_ctx); @@ -161,7 +161,7 @@ static int ejs_ldbAddModify(MprVarHandle eid, int argc, struct MprVar **argv, return -1; } - mpr_Return(eid, mprCreateBoolVar(ret == 0)); + mpr_Return(eid, mprLdbResult(ldb, ret, NULL)); return 0; } @@ -197,7 +197,7 @@ static int ejs_ldbDelete(MprVarHandle eid, int argc, struct MprVar **argv) talloc_free(dn); - mpr_Return(eid, mprCreateBoolVar(ret == 0)); + mpr_Return(eid, mprLdbResult(ldb, ret, NULL)); return 0; } @@ -234,7 +234,7 @@ static int ejs_ldbRename(MprVarHandle eid, int argc, struct MprVar **argv) talloc_free(dn1); talloc_free(dn2); - mpr_Return(eid, mprCreateBoolVar(ret == 0)); + mpr_Return(eid, mprLdbResult(ldb, ret, NULL)); return 0; } diff --git a/source4/scripting/libjs/provision.js b/source4/scripting/libjs/provision.js index 9f24b5e48b..b50e9b5bcf 100644 --- a/source4/scripting/libjs/provision.js +++ b/source4/scripting/libjs/provision.js @@ -23,7 +23,7 @@ function install_ok(session_info, credentials) return false; } var res = ldb.search("(cn=Administrator)"); - if (res.length != 1) { + if (res.error != 0 || res.msgs.length != 1) { return false; } return true; @@ -72,7 +72,7 @@ function setup_name_mapping(info, ldb, sid, unixname) var attrs = new Array("dn"); var res = ldb.search(sprintf("objectSid=%s", sid), info.subobj.DOMAINDN, ldb.SCOPE_SUBTREE, attrs); - if (res.length != 1) { + if (res.error != 0 || res.msgs.length != 1) { info.message("Failed to find record for objectSid %s\n", sid); return false; } @@ -82,9 +82,9 @@ changetype: modify replace: unixName unixName: %s ", - res[0].dn, unixname); + res.msgs[0].dn, unixname); var ok = ldb.modify(mod); - if (!ok) { + if (ok.error != 0) { info.message("name mapping for %s failed - %s\n", sid, ldb.errstring()); return false; @@ -172,20 +172,20 @@ function ldb_erase(ldb) var basedn = ""; var res = ldb.search("(&(|(objectclass=*)(dn=*))(!(dn=@BASEINFO)))", basedn, ldb.SCOPE_SUBTREE, attrs); var i; - if (typeof(res) == "undefined") { + if (res.error != 0) { ldb_delete(ldb); return; } - for (i=0;i 0); + assert(res.error == 0); + assert (res.msgs.length > 0); println("Testing that we do find configuration elements and user elements at the same time"); var attrs = new Array("cn"); var res = gc_ldb.search("(|(objectClass=crossRef)(objectClass=person))", base_dn, ldb.SCOPE_SUBTREE, attrs); - assert (res.length > 0); + assert(res.error == 0); + assert (res.msgs.length > 0); println("Testing that we do find configuration elements in the global catlog, with the configuration basedn"); var attrs = new Array("cn"); var res = gc_ldb.search("objectClass=crossRef", configuration_dn, ldb.SCOPE_SUBTREE, attrs); - assert (res.length > 0); + assert(res.error == 0); + assert (res.msgs.length > 0); } println("Testing that we can get at the configuration DN on the main LDAP port"); var attrs = new Array("cn"); var res = ldb.search("objectClass=crossRef", configuration_dn, ldb.SCOPE_SUBTREE, attrs); - assert (res.length > 0); + assert(res.error == 0); + assert (res.msgs.length > 0); } @@ -427,40 +447,46 @@ function basedn_tests(ldb, gc_ldb) println("Testing for all rootDSE attributes"); var attrs = new Array(); var res = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(res.length == 1); + assert(res.error == 0); + assert(res.msgs.length == 1); println("Testing for highestCommittedUSN"); var attrs = new Array("highestCommittedUSN"); var res = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(res.length == 1); - assert(res[0].highestCommittedUSN != undefined); - assert(res[0].highestCommittedUSN != 0); + assert(res.error == 0); + assert(res.msgs.length == 1); + assert(res.msgs[0].highestCommittedUSN != undefined); + assert(res.msgs[0].highestCommittedUSN != 0); println("Testing for netlogon via LDAP"); var attrs = new Array("netlogon"); var res = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(res.length == 0); + assert(res.error == 0); + assert(res.msgs.length == 0); println("Testing for netlogon and highestCommittedUSN via LDAP"); var attrs = new Array("netlogon", "highestCommittedUSN"); var res = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(res.length == 0); + assert(res.error == 0); + assert(res.msgs.length == 0); } function find_basedn(ldb) { var attrs = new Array("defaultNamingContext"); var res = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(res.length == 1); - return res[0].defaultNamingContext; + assert(res.error == 0); + assert(res.msgs.length == 1); + return res.msgs[0].defaultNamingContext; } function find_configurationdn(ldb) { var attrs = new Array("configurationNamingContext"); var res = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(res.length == 1); - return res[0].configurationNamingContext; + assert(res.error == 0); + assert(res.msgs.length == 1); + return res.msgs[0].configurationNamingContext; } /* use command line creds if available */ diff --git a/testprogs/ejs/ldb.js b/testprogs/ejs/ldb.js index 06b6ec7f50..774219a1ab 100755 --- a/testprogs/ejs/ldb.js +++ b/testprogs/ejs/ldb.js @@ -32,33 +32,33 @@ dn: cn=x,cn=test objectClass: foo x: 3 "); - assert(ok); + assert(ok.error == 0); println("Testing ldb.search"); var res = ldb.search("(objectClass=*)"); - assert(res[0].objectClass[0] == "foo"); - assert(res[0].dn == "cn=x,cn=test"); - assert(res[0].x == 3); + assert(res.msgs[0].objectClass[0] == "foo"); + assert(res.msgs[0].dn == "cn=x,cn=test"); + assert(res.msgs[0].x == 3); ok = ldb.add(" dn: cn=x2,cn=test objectClass: foo x: 4 "); - assert(ok); + assert(ok.error == 0); var attrs = new Array("x"); res = ldb.search("x=4", NULL, ldb.SCOPE_DEFAULT, attrs); - assert(res[0].x == 4); - assert(res[0].objectClass == undefined); - assert(res[0].dn == "cn=x2,cn=test"); + assert(res.msgs[0].x == 4); + assert(res.msgs[0].objectClass == undefined); + assert(res.msgs[0].dn == "cn=x2,cn=test"); ok = ldb.del("cn=x,cn=test"); - assert(ok); + assert(ok.error == 0); ok = ldb.rename("cn=x2,cn=test", "cn=x3,cn=test"); - assert(ok); + assert(ok.error == 0); res = ldb.search("x=4", NULL, ldb.SCOPE_DEFAULT, attrs); - assert(res[0].dn == "cn=x3,cn=test"); + assert(res.msgs[0].dn == "cn=x3,cn=test"); ok = ldb.modify(" dn: cn=x3,cn=test @@ -68,13 +68,13 @@ x: 7 "); res = ldb.search("x=7"); - assert(res.length == 1); - assert(res[0].x.length == 2); + assert(res.msgs.length == 1); + assert(res.msgs[0].x.length == 2); /* Check a few things before we add modules */ - assert(res[0].objectGUID == undefined); - assert(res[0].createTimestamp == undefined); - assert(res[0].whenCreated == undefined); + assert(res.msgs[0].objectGUID == undefined); + assert(res.msgs[0].createTimestamp == undefined); + assert(res.msgs[0].whenCreated == undefined); } @@ -111,23 +111,23 @@ dn: @ATTRIBUTES cn: CASE_INSENSITIVE caseattr: CASE_INSENSITIVE "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } /* Confirm that the attributes were replicated */ var res_attrs = parttestldb.search("cn=*", "@ATTRIBUTES", parttestldb.SCOPE_BASE); - assert(res_attrs[0].cn == "CASE_INSENSITIVE"); + assert(res_attrs.msgs[0].cn == "CASE_INSENSITIVE"); ok = ldb.add(" dn: cn=x8,cn=PartTest objectClass: foo x: 8 "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } ok = ldb.add(" @@ -136,9 +136,9 @@ objectClass: foo x: 9 cn: X9 "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } ok = ldb.add(" @@ -147,59 +147,59 @@ objectClass: foo x: 9 cn: X9 "); - if (ok) { + if (ok.error == 0) { println("Should have failed to add cn=X9,cn=PartTest"); - assert(!ok); + assert(ok.error != 0); } var res = ldb.search("x=8", "cn=PartTest", ldb.SCOPE_DEFAULT); - assert(res[0].objectGUID != undefined); - assert(res[0].uSNCreated != undefined); - assert(res[0].uSNChanged != undefined); - assert(res[0].createTimestamp == undefined); - assert(res[0].whenCreated != undefined); - assert(res[0].name == "x8"); - assert(res[0].cn == "x8"); + assert(res.msgs[0].objectGUID != undefined); + assert(res.msgs[0].uSNCreated != undefined); + assert(res.msgs[0].uSNChanged != undefined); + assert(res.msgs[0].createTimestamp == undefined); + assert(res.msgs[0].whenCreated != undefined); + assert(res.msgs[0].name == "x8"); + assert(res.msgs[0].cn == "x8"); /* Confirm that this ended up in the correct LDB */ var res_otherldb = parttestldb.search("x=8", "cn=PartTest", parttestldb.SCOPE_DEFAULT); - assert(res_otherldb[0].objectGUID != undefined); - assert(res_otherldb[0].createTimestamp == undefined); - assert(res_otherldb[0].whenCreated != undefined); - assert(res_otherldb[0].name == "x8"); - assert(res_otherldb[0].cn == "x8"); + assert(res_otherldb.msgs[0].objectGUID != undefined); + assert(res_otherldb.msgs[0].createTimestamp == undefined); + assert(res_otherldb.msgs[0].whenCreated != undefined); + assert(res_otherldb.msgs[0].name == "x8"); + assert(res_otherldb.msgs[0].cn == "x8"); var attrs = new Array("*", "createTimestamp"); var res2 = ldb.search("x=9", "cn=PartTest", ldb.SCOPE_DEFAULT, attrs); - assert(res2[0].objectGUID != undefined); - assert(res2[0].createTimestamp != undefined); - assert(res2[0].whenCreated != undefined); - assert(res2[0].name == "x9"); - assert(res2[0].cn == "x9"); + assert(res2.msgs[0].objectGUID != undefined); + assert(res2.msgs[0].createTimestamp != undefined); + assert(res2.msgs[0].whenCreated != undefined); + assert(res2.msgs[0].name == "x9"); + assert(res2.msgs[0].cn == "x9"); - assert(res[0].objectGUID != res2[0].objectGUID); + assert(res.msgs[0].objectGUID != res2.msgs[0].objectGUID); var attrs = new Array("*"); var res3 = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(res3[0].cn == undefined); - assert(res3[0].distinguishedName == undefined); - assert(res3[0].name == undefined); - assert(res3[0].currentTime != undefined); - assert(res3[0].highestCommittedUSN != undefined); - - assert(res3[0].namingContexts[0] == "cn=Sub,cn=Sub,cn=PartTest"); - assert(res3[0].namingContexts[1] == "cn=Sub,cn=PartTest"); - assert(res3[0].namingContexts[2] == "cn=PartTest"); - assert(res3[0].namingContexts[3] == "cn=SideTest"); - var usn = res3[0].highestCommittedUSN; + assert(res3.msgs[0].cn == undefined); + assert(res3.msgs[0].distinguishedName == undefined); + assert(res3.msgs[0].name == undefined); + assert(res3.msgs[0].currentTime != undefined); + assert(res3.msgs[0].highestCommittedUSN != undefined); + + assert(res3.msgs[0].namingContexts[0] == "cn=Sub,cn=Sub,cn=PartTest"); + assert(res3.msgs[0].namingContexts[1] == "cn=Sub,cn=PartTest"); + assert(res3.msgs[0].namingContexts[2] == "cn=PartTest"); + assert(res3.msgs[0].namingContexts[3] == "cn=SideTest"); + var usn = res3.msgs[0].highestCommittedUSN; /* Start a transaction. We are going to abort it later, to * show we clean up all partitions */ ok = ldb.transaction_start() if (!ok) { - println("Failed to start a transaction: " + ldb.errstring()); - assert(ok); + println("Failed to start a transaction: " + ok.errstr); + assert(ok.error == 0); } @@ -208,53 +208,53 @@ dn: cn=x10,cn=parttest objectClass: foo x: 10 "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } var attrs = new Array("highestCommittedUSN"); var res4 = ldb.search("", "", ldb.SCOPE_BASE, attrs); - var usn2 = res4[0].highestCommittedUSN; - assert(usn < res4[0].highestCommittedUSN); + var usn2 = res4.msgs[0].highestCommittedUSN; + assert(usn < res4.msgs[0].highestCommittedUSN); ok = ldb.add(" dn: cn=x11,cn=sub,cn=parttest objectClass: foo x: 11 "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } var attrs = new Array("highestCommittedUSN"); var res5 = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(usn2 < res5[0].highestCommittedUSN); + assert(usn2 < res5.msgs[0].highestCommittedUSN); var attrs = new Array("*", "createTimestamp"); var res6 = ldb.search("x=11", "cn=parttest", ldb.SCOPE_SUB, attrs); - assert(res6.length == 0); + assert(res6.msgs.length == 0); var attrs = new Array("*", "createTimestamp"); var res7 = ldb.search("x=10", "cn=sub,cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(res7.length == 0); + assert(res7.msgs.length == 0); var res8 = ldb.search("x=11", "cn=sub,cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(res8[0].objectGUID == undefined); /* The objectGUID module is not loaded here */ - assert(res8[0].uSNCreated == undefined); /* The objectGUID module is not loaded here */ - assert(res8[0].name == "x11"); - assert(res8[0].cn == "x11"); + assert(res8.msgs[0].objectGUID == undefined); /* The objectGUID module is not loaded here */ + assert(res8.msgs[0].uSNCreated == undefined); /* The objectGUID module is not loaded here */ + assert(res8.msgs[0].name == "x11"); + assert(res8.msgs[0].cn == "x11"); ok = ldb.add(" dn: caseattr=XY,cn=PartTest objectClass: foo x: Y "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } ok = ldb.add(" @@ -263,9 +263,9 @@ objectClass: foo x: Z caseattr: XZ "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } ok = ldb.add(" @@ -274,9 +274,9 @@ objectClass: foo x: Z caseattr: xz "); - if (ok) { + if (ok.error == 0) { println("Should have failed to add caseattr=xz,cn=PartTest"); - assert(!ok); + assert(ok.error != 0); } ok = ldb.add(" @@ -285,9 +285,9 @@ objectClass: foo x: Z caseattr2: XZ "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } ok = ldb.add(" @@ -296,35 +296,35 @@ objectClass: foo x: Z caseattr2: Xz "); - if (!ok) { - println("Failed to add: " + ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println("Failed to add: " + ok.errstr); + assert(ok.error == 0); } var resX = ldb.search("caseattr=xz", "cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(resX.length == 1); - assert(resX[0].objectGUID != undefined); - assert(resX[0].createTimestamp != undefined); - assert(resX[0].whenCreated != undefined); - assert(resX[0].name == "XZ"); + assert(resX.msgs.length == 1); + assert(resX.msgs[0].objectGUID != undefined); + assert(resX.msgs[0].createTimestamp != undefined); + assert(resX.msgs[0].whenCreated != undefined); + assert(resX.msgs[0].name == "XZ"); var rescount = ldb.search("(|(caseattr=*)(cn=*))", "cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(rescount.length == 5); + assert(rescount.msgs.length == 5); /* Check this attribute is *not* case sensitive */ var resXcount = ldb.search("caseattr=x*", "cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(resXcount.length == 2); + assert(resXcount.msgs.length == 2); /* Check that this attribute *is* case sensitive */ var resXcount2 = ldb.search("caseattr2=xz", "cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(resXcount2.length == 0); + assert(resXcount2.msgs.length == 0); /* Now abort the transaction to show that even with * partitions, it is aborted everywhere */ ok = ldb.transaction_cancel(); if (!ok) { - println("Failed to cancel a transaction: " + ldb.errstring()); + println("Failed to cancel a transaction: " + ok.errstr); assert(ok); } @@ -332,19 +332,19 @@ caseattr2: Xz var attrs = new Array("highestCommittedUSN"); var res9 = ldb.search("", "", ldb.SCOPE_BASE, attrs); - assert(usn == res9[0].highestCommittedUSN); + assert(usn == res9.msgs[0].highestCommittedUSN); var attrs = new Array("*"); var res10 = ldb.search("x=11", "cn=sub,cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(res10.length == 0); + assert(res10.msgs.length == 0); var attrs = new Array("*"); var res11 = ldb.search("x=10", "cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(res11.length == 0); + assert(res11.msgs.length == 0); var attrs = new Array("*"); var res12 = ldb.search("caseattr=*", "cn=parttest", ldb.SCOPE_DEFAULT, attrs); - assert(res12.length == 0); + assert(res12.msgs.length == 0); } diff --git a/testprogs/ejs/minschema.js b/testprogs/ejs/minschema.js index 01fcc411c9..ffa6db6669 100755 --- a/testprogs/ejs/minschema.js +++ b/testprogs/ejs/minschema.js @@ -157,9 +157,9 @@ function get_object_cn(ldb, name) { var res = ldb.search(sprintf("(ldapDisplayName=%s)", name), rootDse.schemaNamingContext, ldb.SCOPE_SUBTREE, attrs); assert(res != undefined); - assert(res.length == 1); + assert(res.msgs.length == 1); - var cn = res[0]["cn"]; + var cn = res.msgs[0]["cn"]; assert(cn != undefined); if (typeof(cn) == "string") { return cn; @@ -287,8 +287,8 @@ function find_objectclass_properties(ldb, o) { sprintf("(ldapDisplayName=%s)", o.name), rootDse.schemaNamingContext, ldb.SCOPE_SUBTREE, class_attrs); assert(res != undefined); - assert(res.length == 1); - var msg = res[0]; + assert(res.msgs.length == 1); + var msg = res.msgs[0]; var a; for (a in msg) { o[a] = msg[a]; @@ -303,8 +303,8 @@ function find_attribute_properties(ldb, o) { sprintf("(ldapDisplayName=%s)", o.name), rootDse.schemaNamingContext, ldb.SCOPE_SUBTREE, attrib_attrs); assert(res != undefined); - assert(res.length == 1); - var msg = res[0]; + assert(res.msgs.length == 1); + var msg = res.msgs[0]; var a; for (a in msg) { /* special case for oMObjectClass, which is a binary object */ @@ -332,18 +332,18 @@ function find_objectclass_auto(ldb, o) { var ldif = "dn: " + testdn; ldif = ldif + "\nobjectClass: " + o.name; ok = ldb.add(ldif); - if (!ok) { - dprintf("error adding %s: %s\n", o.name, ldb.errstring()); + if (ok.error != 0) { + dprintf("error adding %s: %s\n", o.name, ok.errstr); dprintf("%s\n", ldif); return; } var res = ldb.search("", testdn, ldb.SCOPE_BASE); ok = ldb.del(testdn); - assert(ok); + assert(ok.error == 0); var a; - for (a in res[0]) { + for (a in res.msgs[0]) { attributes[a].autocreate = true; } } @@ -363,8 +363,8 @@ function expand_objectclass(ldb, o) { var a; dprintf("Expanding class %s\n", o.name); assert(res != undefined); - assert(res.length == 1); - var msg = res[0]; + assert(res.msgs.length == 1); + var msg = res.msgs[0]; for (a=0;a= 1); - assert(msg[0].sambaSID == "S-1-5-21-4231626423-2410014848-2360679739-2001"); - assert(msg[0].displayName == "Niemand"); + assert(msg.error == 0); + assert(msg.msgs.length >= 1); + assert(msg.msgs[0].sambaSID == "S-1-5-21-4231626423-2410014848-2360679739-2001"); + assert(msg.msgs[0].displayName == "Niemand"); println("Adding attribute..."); ok = ldb.modify(" @@ -175,17 +183,18 @@ changetype: modify add: description description: Blah "); - if (!ok) { - println(ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println(ok.errstr); + assert(ok.error == 0); } - assert(ok); + assert(ok.error == 0); println("Checking whether changes are still there..."); msg = ldb.search("(cn=Niemand)"); - assert(msg.length >= 1); - assert(msg[0].cn == "Niemand"); - assert(msg[0].description == "Blah"); + assert(msg.error == 0); + assert(msg.msgs.length >= 1); + assert(msg.msgs[0].cn == "Niemand"); + assert(msg.msgs[0].description == "Blah"); println("Modifying attribute..."); ok = ldb.modify(" @@ -194,16 +203,17 @@ changetype: modify replace: description description: Blie "); - if (!ok) { - println(ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println(ok.errstr); + assert(ok.error == 0); } - assert(ok); + assert(ok.error == 0); println("Checking whether changes are still there..."); msg = ldb.search("(cn=Niemand)"); - assert(msg.length >= 1); - assert(msg[0].description == "Blie"); + assert(msg.error == 0); + assert(msg.msgs.length >= 1); + assert(msg.msgs[0].description == "Blie"); println("Deleting attribute..."); ok = ldb.modify(" @@ -211,36 +221,39 @@ dn: cn=Niemand,cn=Users,dc=vernstok,dc=nl changetype: modify delete: description "); - if (!ok) { - println(ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println(ok.errstr); + assert(ok.error == 0); } - assert(ok); + assert(ok.error == 0); println("Checking whether changes are no longer there..."); msg = ldb.search("(cn=Niemand)"); - assert(msg.length >= 1); - assert(msg[0].description == undefined); + assert(msg.error == 0); + assert(msg.msgs.length >= 1); + assert(msg.msgs[0].description == undefined); println("Renaming record..."); ok = ldb.rename("cn=Niemand,cn=Users,dc=vernstok,dc=nl", "cn=Niemand2,cn=Users,dc=vernstok,dc=nl"); - assert(ok); + assert(ok.error == 0); println("Checking whether DN has changed..."); msg = ldb.search("(cn=Niemand2)"); - assert(msg.length == 1); - assert(msg[0].dn == "cn=Niemand2,cn=Users,dc=vernstok,dc=nl"); + assert(msg.error == 0); + assert(msg.msgs.length == 1); + assert(msg.msgs[0].dn == "cn=Niemand2,cn=Users,dc=vernstok,dc=nl"); println("Deleting record..."); ok = ldb.del("cn=Niemand2,cn=Users,dc=vernstok,dc=nl"); - if (!ok) { - println(ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println(ok.errstr); + assert(ok.error == 0); } println("Checking whether record is gone..."); msg = ldb.search("(cn=Niemand2)"); - assert(msg.length == 0); + assert(msg.error == 0); + assert(msg.msgs.length == 0); } function test_map_search(ldb, s3, s4) @@ -287,9 +300,9 @@ description: y ldif = substitute_var(ldif, s4); assert(ldif != undefined); var ok = ldb.add(ldif); - if (!ok) { - println(ldb.errstring()); - assert(ok); + if (ok.error != 0) { + println(ok.errstr); + assert(ok.error == 0); } /* Add a set of remote records */ @@ -323,7 +336,7 @@ description: y ldif = substitute_var(ldif, s3); assert(ldif != undefined); var ok = s3.db.add(ldif); - assert(ok); + assert(ok.error == 0); println("Testing search by DN"); @@ -331,81 +344,81 @@ description: y dn = s4.dn("cn=A"); attrs = new Array("objectCategory", "lastLogon"); res = ldb.search("", dn, ldb.SCOPE_BASE, attrs); - assert(res != undefined); - assert(res.length == 1); - assert(res[0].dn == dn); - assert(res[0].objectCategory == undefined); - assert(res[0].lastLogon == "x"); + assert(res.error == 0); + assert(res.msgs.length == 1); + assert(res.msgs[0].dn == dn); + assert(res.msgs[0].objectCategory == undefined); + assert(res.msgs[0].lastLogon == "x"); /* Search remote record by remote DN */ dn = s3.dn("cn=A"); attrs = new Array("objectCategory", "lastLogon", "sambaLogonTime"); res = s3.db.search("", dn, ldb.SCOPE_BASE, attrs); - assert(res != undefined); - assert(res.length == 1); - assert(res[0].dn == dn); - assert(res[0].objectCategory == undefined); - assert(res[0].lastLogon == undefined); - assert(res[0].sambaLogonTime == "x"); + assert(res.error == 0); + assert(res.msgs.length == 1); + assert(res.msgs[0].dn == dn); + assert(res.msgs[0].objectCategory == undefined); + assert(res.msgs[0].lastLogon == undefined); + assert(res.msgs[0].sambaLogonTime == "x"); /* Search split record by local DN */ dn = s4.dn("cn=X"); attrs = new Array("objectCategory", "lastLogon"); res = ldb.search("", dn, ldb.SCOPE_BASE, attrs); - assert(res != undefined); - assert(res.length == 1); - assert(res[0].dn == dn); - assert(res[0].objectCategory == "x"); - assert(res[0].lastLogon == "x"); + assert(res.error == 0); + assert(res.msgs.length == 1); + assert(res.msgs[0].dn == dn); + assert(res.msgs[0].objectCategory == "x"); + assert(res.msgs[0].lastLogon == "x"); /* Search split record by remote DN */ dn = s3.dn("cn=X"); attrs = new Array("objectCategory", "lastLogon", "sambaLogonTime"); res = s3.db.search("", dn, ldb.SCOPE_BASE, attrs); - assert(res != undefined); - assert(res.length == 1); - assert(res[0].dn == dn); - assert(res[0].objectCategory == undefined); - assert(res[0].lastLogon == undefined); - assert(res[0].sambaLogonTime == "x"); + assert(res.error == 0); + assert(res.msgs.length == 1); + assert(res.msgs[0].dn == dn); + assert(res.msgs[0].objectCategory == undefined); + assert(res.msgs[0].lastLogon == undefined); + assert(res.msgs[0].sambaLogonTime == "x"); println("Testing search by attribute"); /* Search by ignored attribute */ attrs = new Array("objectCategory", "lastLogon"); res = ldb.search("(revision=x)", NULL, ldb. SCOPE_DEFAULT, attrs); - assert(res != undefined); - assert(res.length == 2); - assert(res[0].dn == s4.dn("cn=Y")); - assert(res[0].objectCategory == "y"); - assert(res[0].lastLogon == "y"); - assert(res[1].dn == s4.dn("cn=X")); - assert(res[1].objectCategory == "x"); - assert(res[1].lastLogon == "x"); + assert(res.error == 0); + assert(res.msgs.length == 2); + assert(res.msgs[0].dn == s4.dn("cn=Y")); + assert(res.msgs[0].objectCategory == "y"); + assert(res.msgs[0].lastLogon == "y"); + assert(res.msgs[1].dn == s4.dn("cn=X")); + assert(res.msgs[1].objectCategory == "x"); + assert(res.msgs[1].lastLogon == "x"); /* Search by kept attribute */ attrs = new Array("objectCategory", "lastLogon"); res = ldb.search("(description=y)", NULL, ldb. SCOPE_DEFAULT, attrs); - assert(res != undefined); - assert(res.length == 2); - assert(res[0].dn == s4.dn("cn=Z")); - assert(res[0].objectCategory == "z"); - assert(res[0].lastLogon == "z"); - assert(res[1].dn == s4.dn("cn=C")); - assert(res[1].objectCategory == undefined); - assert(res[1].lastLogon == "z"); + assert(res.error == 0); + assert(res.msgs.length == 2); + assert(res.msgs[0].dn == s4.dn("cn=Z")); + assert(res.msgs[0].objectCategory == "z"); + assert(res.msgs[0].lastLogon == "z"); + assert(res.msgs[1].dn == s4.dn("cn=C")); + assert(res.msgs[1].objectCategory == undefined); + assert(res.msgs[1].lastLogon == "z"); /* Search by renamed attribute */ attrs = new Array("objectCategory", "lastLogon"); res = ldb.search("(badPwdCount=x)", NULL, ldb. SCOPE_DEFAULT, attrs); - assert(res != undefined); - assert(res.length == 2); - assert(res[0].dn == s4.dn("cn=B")); - assert(res[0].objectCategory == undefined); - assert(res[0].lastLogon == "y"); - assert(res[1].dn == s4.dn("cn=A")); - assert(res[1].objectCategory == undefined); - assert(res[1].lastLogon == "x"); + assert(res.error == 0); + assert(res.msgs.length == 2); + assert(res.msgs[0].dn == s4.dn("cn=B")); + assert(res.msgs[0].objectCategory == undefined); + assert(res.msgs[0].lastLogon == "y"); + assert(res.msgs[1].dn == s4.dn("cn=A")); + assert(res.msgs[1].objectCategory == undefined); + assert(res.msgs[1].lastLogon == "x"); /* Search by converted attribute */ attrs = new Array("objectCategory", "lastLogon", "objectSid"); @@ -415,28 +428,28 @@ description: y res = ldb.search("(objectSid=S-1-5-21-4231626423-2410014848-2360679739-552)", NULL, ldb. SCOPE_DEFAULT, attrs); */ res = ldb.search("(objectSid=*)", NULL, ldb. SCOPE_DEFAULT, attrs); - assert(res != undefined); - assert(res.length == 2); - assert(res[0].dn == s4.dn("cn=X")); - assert(res[0].objectCategory == "x"); - assert(res[0].lastLogon == "x"); - assert(res[0].objectSid == "S-1-5-21-4231626423-2410014848-2360679739-552"); - assert(res[1].dn == s4.dn("cn=A")); - assert(res[1].objectCategory == undefined); - assert(res[1].lastLogon == "x"); - assert(res[1].objectSid == "S-1-5-21-4231626423-2410014848-2360679739-552"); + assert(res.error == 0); + assert(res.msgs.length == 2); + assert(res.msgs[0].dn == s4.dn("cn=X")); + assert(res.msgs[0].objectCategory == "x"); + assert(res.msgs[0].lastLogon == "x"); + assert(res.msgs[0].objectSid == "S-1-5-21-4231626423-2410014848-2360679739-552"); + assert(res.msgs[1].dn == s4.dn("cn=A")); + assert(res.msgs[1].objectCategory == undefined); + assert(res.msgs[1].lastLogon == "x"); + assert(res.msgs[1].objectSid == "S-1-5-21-4231626423-2410014848-2360679739-552"); /* Search by generated attribute */ /* In most cases, this even works when the mapping is missing * a `convert_operator' by enumerating the remote db. */ attrs = new Array("objectCategory", "lastLogon", "primaryGroupID"); res = ldb.search("(primaryGroupID=512)", NULL, ldb. SCOPE_DEFAULT, attrs); - assert(res != undefined); - assert(res.length == 1); - assert(res[0].dn == s4.dn("cn=A")); - assert(res[0].objectCategory == undefined); - assert(res[0].lastLogon == "x"); - assert(res[0].primaryGroupID == "512"); + assert(res.error == 0); + assert(res.msgs.length == 1); + assert(res.msgs[0].dn == s4.dn("cn=A")); + assert(res.msgs[0].objectCategory == undefined); + assert(res.msgs[0].lastLogon == "x"); + assert(res.msgs[0].primaryGroupID == "512"); /* TODO: There should actually be two results, A and X. The * primaryGroupID of X seems to get corrupted somewhere, and the @@ -445,10 +458,10 @@ description: y * objectSid seems to be fine in the previous search for objectSid... */ /* res = ldb.search("(primaryGroupID=*)", NULL, ldb. SCOPE_DEFAULT, attrs); - println(res.length + " results found"); - for (i=0;i