From 889e03617d6153040bbf462b631d9e752220281b Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 16 Mar 2011 21:50:59 +0100 Subject: s3: Fix Coverity ID 2232, REVERSE_INULL No point checking for !cli after dereferencing it --- source3/rpc_client/cli_pipe.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c index ebbe849ac7..0109bdae72 100644 --- a/source3/rpc_client/cli_pipe.c +++ b/source3/rpc_client/cli_pipe.c @@ -3256,7 +3256,7 @@ NTSTATUS cli_get_session_key(TALLOC_CTX *mem_ctx, struct rpc_pipe_client *cli, DATA_BLOB *session_key) { - struct pipe_auth_data *a = cli->auth; + struct pipe_auth_data *a; struct schannel_state *schannel_auth; struct auth_ntlmssp_state *ntlmssp_ctx; struct spnego_context *spnego_ctx; @@ -3268,7 +3268,9 @@ NTSTATUS cli_get_session_key(TALLOC_CTX *mem_ctx, return NT_STATUS_INVALID_PARAMETER; } - if (!cli->auth) { + a = cli->auth; + + if (a == NULL) { return NT_STATUS_INVALID_PARAMETER; } -- cgit