From 8d06233d1115f56e586aa49a7871fbeb8b0ff76d Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Thu, 24 Feb 2005 03:45:09 +0000 Subject: r5536: Avoid intermediate copy of NT and LM responses in NETLOGON client. This copy was length-limited, which broke when the NTLMv2 response was more than 128 bytes in length. Andrew Bartlett (This used to be commit bae18aaaff7f9eff90db566b9a254a11d281aa01) --- source3/rpc_parse/parse_net.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/source3/rpc_parse/parse_net.c b/source3/rpc_parse/parse_net.c index b26083b89e..d7bdca4df9 100644 --- a/source3/rpc_parse/parse_net.c +++ b/source3/rpc_parse/parse_net.c @@ -1174,28 +1174,14 @@ void init_id_info2(NET_ID_INFO_2 * id, const char *domain_name, const uchar * lm_chal_resp, size_t lm_chal_resp_len, const uchar * nt_chal_resp, size_t nt_chal_resp_len) { - unsigned char lm_owf[24]; - unsigned char nt_owf[128]; DEBUG(5,("init_id_info2: %d\n", __LINE__)); id->ptr_id_info2 = 1; - id->param_ctrl = param_ctrl; init_logon_id(&id->logon_id, log_id_low, log_id_high); - if (nt_chal_resp) { - /* oops. can only send what-ever-it-is direct */ - memcpy(nt_owf, nt_chal_resp, MIN(sizeof(nt_owf), nt_chal_resp_len)); - nt_chal_resp = nt_owf; - } - if (lm_chal_resp) { - /* oops. can only send what-ever-it-is direct */ - memcpy(lm_owf, lm_chal_resp, MIN(sizeof(lm_owf), lm_chal_resp_len)); - lm_chal_resp = lm_owf; - } - memcpy(id->lm_chal, lm_challenge, sizeof(id->lm_chal)); init_str_hdr(&id->hdr_nt_chal_resp, nt_chal_resp_len, nt_chal_resp_len, (nt_chal_resp != NULL) ? 1 : 0); init_str_hdr(&id->hdr_lm_chal_resp, lm_chal_resp_len, lm_chal_resp_len, (lm_chal_resp != NULL) ? 1 : 0); -- cgit