From 9061aae9b4bfed051b4c08b971561297710ef369 Mon Sep 17 00:00:00 2001 From: Martin Pool Date: Thu, 20 Feb 2003 03:33:20 +0000 Subject: (Merge from APPLIANCE_HEAD) CR1829: Fix memory leak when unpacking 'B' buffers in Python. (PyList_Append creates a new reference to the added object, and so we have to release the existing one.) (This used to be commit 55e114f596e0edfdf176cabdbcfe7f01fae6f8aa) --- source3/python/py_tdbpack.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source3/python/py_tdbpack.c b/source3/python/py_tdbpack.c index 6181a4918e..8aa4ee316a 100644 --- a/source3/python/py_tdbpack.c +++ b/source3/python/py_tdbpack.c @@ -638,6 +638,9 @@ pytdbunpack_buffer(char **pbuf, int *plen, PyObject *val_list) if (PyList_Append(val_list, str_obj) == -1) goto failed; + Py_DECREF(len_obj); + Py_DECREF(str_obj); + return val_list; failed: -- cgit