From 91910fe898e2f8ad405c5790aa1a20e82a9f8aac Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Thu, 29 Aug 2013 16:38:08 +0200 Subject: s3:winbind: fail ads_cached_connection_connect() if realm == NULL MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This prevents segfaults when e.g. a previous SMB_STRDUP failed.. Signed-off-by: Michael Adam Reviewed-by: Günther Deschner Autobuild-User(master): Günther Deschner Autobuild-Date(master): Thu Aug 29 18:54:28 CEST 2013 on sn-devel-104 --- source3/winbindd/winbindd_ads.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source3/winbindd/winbindd_ads.c b/source3/winbindd/winbindd_ads.c index c33b1bc3bf..4c2638900f 100644 --- a/source3/winbindd/winbindd_ads.c +++ b/source3/winbindd/winbindd_ads.c @@ -86,6 +86,10 @@ static ADS_STATUS ads_cached_connection_connect(ADS_STRUCT **adsp, struct sockaddr_storage dc_ss; fstring dc_name; + if (realm == NULL) { + return ADS_ERROR_NT(NT_STATUS_UNSUCCESSFUL); + } + /* we don't want this to affect the users ccache */ setenv("KRB5CCNAME", WINBIND_CCACHE_NAME, 1); -- cgit