From a0a787ad78a72b1bb9e7f9f7f28d18a4023a666b Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 21 Oct 2009 16:07:22 +1100 Subject: s4:rpc_server Ensure we talloc_free handles when we delete objects If we don't talloc_free the handle, we leak the memory onto the long-term context. Andrew Bartlett --- source4/rpc_server/samr/dcesrv_samr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c index 5b9aa91ded..f4ada2c7c7 100644 --- a/source4/rpc_server/samr/dcesrv_samr.c +++ b/source4/rpc_server/samr/dcesrv_samr.c @@ -2300,6 +2300,7 @@ static NTSTATUS dcesrv_samr_DeleteDomainGroup(struct dcesrv_call_state *dce_call return NT_STATUS_UNSUCCESSFUL; } + talloc_free(h); ZERO_STRUCTP(r->out.group_handle); return NT_STATUS_OK; @@ -2676,6 +2677,7 @@ static NTSTATUS dcesrv_samr_DeleteDomAlias(struct dcesrv_call_state *dce_call, T return NT_STATUS_UNSUCCESSFUL; } + talloc_free(h); ZERO_STRUCTP(r->out.alias_handle); return NT_STATUS_OK; @@ -2962,6 +2964,7 @@ static NTSTATUS dcesrv_samr_DeleteUser(struct dcesrv_call_state *dce_call, TALLO return NT_STATUS_UNSUCCESSFUL; } + talloc_free(h); ZERO_STRUCTP(r->out.user_handle); return NT_STATUS_OK; -- cgit