From a255f9ce713b29552722ec73e4038226959e1c8e Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 17 Dec 2008 17:16:50 +0100 Subject: s3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32() All callers expect 0 an success and -1 on error. metze --- source3/include/proto.h | 2 +- source3/lib/dbwrap_util.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/source3/include/proto.h b/source3/include/proto.h index cffb8f7325..5a3776b005 100644 --- a/source3/include/proto.h +++ b/source3/include/proto.h @@ -441,7 +441,7 @@ int32_t dbwrap_fetch_int32(struct db_context *db, const char *keystr); int dbwrap_store_int32(struct db_context *db, const char *keystr, int32_t v); bool dbwrap_fetch_uint32(struct db_context *db, const char *keystr, uint32_t *val); -bool dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v); +int dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v); uint32_t dbwrap_change_uint32_atomic(struct db_context *db, const char *keystr, uint32_t *oldval, uint32_t change_val); int32 dbwrap_change_int32_atomic(struct db_context *db, const char *keystr, diff --git a/source3/lib/dbwrap_util.c b/source3/lib/dbwrap_util.c index ddc613150b..3be3a49e7d 100644 --- a/source3/lib/dbwrap_util.c +++ b/source3/lib/dbwrap_util.c @@ -78,7 +78,7 @@ bool dbwrap_fetch_uint32(struct db_context *db, const char *keystr, return true; } -bool dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v) +int dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v) { struct db_record *rec; uint32 v_store; @@ -86,7 +86,7 @@ bool dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v) rec = db->fetch_locked(db, NULL, string_term_tdb_data(keystr)); if (rec == NULL) { - return false; + return -1; } SIVAL(&v_store, 0, v); -- cgit