From a6cc04a20089e8fbcce138c271961c37ddcd6c34 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Mon, 1 Jun 2009 13:13:07 +1000 Subject: overallocate all records by 25% This greatly reduces the fragmentation of databases where records tend to grow slowly by a small amount each time. The case where this is most seen is the ldb index records. Adding this overallocation reduced the size of the resulting database by more than 20x when running a test that adds 10k users. --- lib/tdb/common/freelist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/tdb/common/freelist.c b/lib/tdb/common/freelist.c index 2f2a4c379b..3bc3965141 100644 --- a/lib/tdb/common/freelist.c +++ b/lib/tdb/common/freelist.c @@ -284,6 +284,9 @@ tdb_off_t tdb_allocate(struct tdb_context *tdb, tdb_len_t length, struct list_st if (tdb_lock(tdb, -1, F_WRLCK) == -1) return 0; + /* over-allocate to reduce fragmentation */ + length *= 1.25; + /* Extra bytes required for tailer */ length += sizeof(tdb_off_t); length = TDB_ALIGN(length, TDB_ALIGNMENT); -- cgit