From aac411b7dddefeafc0762dade882a769fc99069e Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 23 Jul 2006 08:18:31 +0000 Subject: r17199: Add comment to the RID/SID miracle (This used to be commit 4c4ae01c671bd35687af686a34824a96828e6b25) --- source3/rpc_server/srv_lsa_nt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/source3/rpc_server/srv_lsa_nt.c b/source3/rpc_server/srv_lsa_nt.c index 04747406d4..41df870414 100644 --- a/source3/rpc_server/srv_lsa_nt.c +++ b/source3/rpc_server/srv_lsa_nt.c @@ -873,7 +873,12 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p, if (name->type == SID_NAME_UNKNOWN) { name->dom_idx = -1; - /* unknown sids should return the string representation of the SID */ + /* Unknown sids should return the string + * representation of the SID. Windows 2003 behaves + * rather erratic here, in many cases it returns the + * RID as 8 bytes hex, in others it returns the full + * SID. We (Jerry/VL) could not figure out which the + * hard cases are, so leave it with the SID. */ name->name = talloc_asprintf(p->mem_ctx, "%s", sid_string_static(sids[i])); if (name->name == NULL) { -- cgit