From b8055132b1c62dd19981fea2822ab9e1829a8ded Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 25 Apr 2012 17:53:18 +1000 Subject: s4-messaging: Use generate_random() to get a unique ID for messaging clients The call to random() resulted in duplicate values for s3fs configurations which, due to the forked child, all started with the same random seed. A future improvement would be to move to a proven unique value. Andrew Bartlett Autobuild-User: Andrew Bartlett Autobuild-Date: Wed Apr 25 11:43:40 CEST 2012 on sn-devel-104 --- source4/lib/messaging/messaging.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source4/lib/messaging/messaging.c b/source4/lib/messaging/messaging.c index 9c337f65a5..80812c2885 100644 --- a/source4/lib/messaging/messaging.c +++ b/source4/lib/messaging/messaging.c @@ -663,7 +663,8 @@ struct imessaging_context *imessaging_client_init(TALLOC_CTX *mem_ctx, { struct server_id id; ZERO_STRUCT(id); - id.pid = random() % 0x10000000; + id.pid = generate_random() % 0x10000000; + return imessaging_init(mem_ctx, lp_ctx, id, ev, true); } /* -- cgit