From b986a3a9c988c6ec29c0e0a2f8609d5132e952f4 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Thu, 28 Mar 2013 08:55:11 -0700 Subject: Ensure EA value is allocated on the right context. Ensure we free on error condition (tidyup, not a leak). Signed-off-by: Jeremy Allison Reviewed-by: David Disseldorp Autobuild-User(master): David Disseldorp Autobuild-Date(master): Tue Apr 2 21:54:33 CEST 2013 on sn-devel-104 --- source3/smbd/trans2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c index 4cdd2394ca..5781c61943 100644 --- a/source3/smbd/trans2.c +++ b/source3/smbd/trans2.c @@ -350,11 +350,12 @@ static NTSTATUS get_ea_list_from_file_path(TALLOC_CTX *mem_ctx, connection_struc return NT_STATUS_NO_MEMORY; } - status = get_ea_value(mem_ctx, conn, fsp, + status = get_ea_value(listp, conn, fsp, fname, names[i], &listp->ea); if (!NT_STATUS_IS_OK(status)) { + TALLOC_FREE(listp); return status; } -- cgit