From bb1d81bab70125d56cfb3e6caff6a01503f33d3d Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 10 Mar 2010 14:12:28 +0100 Subject: s4:rpc_server/wkssvc: don't reset [out,ref] pointer to 0 r->out.total_entries = 0; should be *r->out.total_entries = 0; Otherwise we fail to marshall the reponse or crash if we run with log level = 10 and trigger the ndr_print functions. All out elements are already setup and initialized by the pidl generated code. metze --- source4/rpc_server/wkssvc/dcesrv_wkssvc.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/source4/rpc_server/wkssvc/dcesrv_wkssvc.c b/source4/rpc_server/wkssvc/dcesrv_wkssvc.c index 4358eb1732..0be956db9d 100644 --- a/source4/rpc_server/wkssvc/dcesrv_wkssvc.c +++ b/source4/rpc_server/wkssvc/dcesrv_wkssvc.c @@ -134,14 +134,8 @@ static WERROR dcesrv_wkssvc_NetrWkstaUserSetInfo(struct dcesrv_call_state *dce_c static WERROR dcesrv_wkssvc_NetWkstaTransportEnum(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx, struct wkssvc_NetWkstaTransportEnum *r) { - r->out.total_entries = 0; - r->out.resume_handle = NULL; - switch (r->in.info->level) { case 0: - r->out.info = talloc(mem_ctx, struct wkssvc_NetWkstaTransportInfo); - W_ERROR_HAVE_NO_MEMORY(r->out.info); - r->out.info->level = r->in.info->level; r->out.info->ctr.ctr0 = talloc(mem_ctx, struct wkssvc_NetWkstaTransportCtr0); W_ERROR_HAVE_NO_MEMORY(r->out.info->ctr.ctr0); -- cgit