From c52e6db8a2d5ef56cac59315f16f70eb9624b5d7 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 14 Nov 2010 15:15:52 +0100 Subject: s3: string_to_sid does thorough syntax checking Autobuild-User: Volker Lendecke Autobuild-Date: Sun Nov 14 14:07:29 UTC 2010 on sn-devel-104 --- source3/utils/smbcacls.c | 4 ++-- source3/utils/smbcquotas.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/source3/utils/smbcacls.c b/source3/utils/smbcacls.c index bb438bab78..9f740f7f34 100644 --- a/source3/utils/smbcacls.c +++ b/source3/utils/smbcacls.c @@ -200,8 +200,8 @@ static bool StringToSid(struct cli_state *cli, struct dom_sid *sid, const char * { enum lsa_SidType type; - if (strncmp(str, "S-", 2) == 0) { - return string_to_sid(sid, str); + if (string_to_sid(sid, str)) { + return true; } return NT_STATUS_IS_OK(cli_lsa_lookup_name(cli, str, &type, sid)); diff --git a/source3/utils/smbcquotas.c b/source3/utils/smbcquotas.c index 6353272d82..63ea269cb5 100644 --- a/source3/utils/smbcquotas.c +++ b/source3/utils/smbcquotas.c @@ -117,8 +117,8 @@ static bool StringToSid(struct dom_sid *sid, const char *str) struct dom_sid *sids = NULL; bool result = True; - if (strncmp(str, "S-", 2) == 0) { - return string_to_sid(sid, str); + if (string_to_sid(sid, str)) { + return true; } if (!cli_open_policy_hnd() || -- cgit