From cc5e23135560f1f298a58ef59ee87f1c195d1854 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Mon, 8 Nov 2010 10:14:50 +1100 Subject: s4-pydrs: validate the DsGetNCChanges response check that object_count matches up with first_object --- source4/scripting/python/samba/drs_utils.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source4/scripting/python/samba/drs_utils.py b/source4/scripting/python/samba/drs_utils.py index 00efd78439..5844b09074 100644 --- a/source4/scripting/python/samba/drs_utils.py +++ b/source4/scripting/python/samba/drs_utils.py @@ -167,6 +167,8 @@ class drs_Replicate: while True: (level, ctr) = self.drs.DsGetNCChanges(self.drs_handle, req_level, req) + if ctr.first_object == None and ctr.object_count != 0: + raise RuntimeError("DsGetNCChanges: NULL first_object with object_count=%u" % (ctr.object_count)) self.net.replicate_chunk(self.replication_state, level, ctr, schema=schema) if ctr.more_data == 0: break -- cgit