From d70803ebe3472cc1930e5732b320d14a47c54d28 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Wed, 28 Jun 2006 00:05:53 +0000 Subject: r16579: Fix Klocwork #2016. Possible null deref. Jeremy. (This used to be commit f6d5bae4a105eee1b1d5b1aaa70a675705345d9e) --- source3/nmbd/nmbd_serverlistdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/nmbd/nmbd_serverlistdb.c b/source3/nmbd/nmbd_serverlistdb.c index cc762ae8d2..ea27f9d4e5 100644 --- a/source3/nmbd/nmbd_serverlistdb.c +++ b/source3/nmbd/nmbd_serverlistdb.c @@ -214,7 +214,7 @@ static uint32 write_this_server_name( struct subnet_record *subrec, struct work_record *iwork; /* Go through all the subnets we have already seen. */ - for (ssub = FIRST_SUBNET; ssub != subrec; ssub = NEXT_SUBNET_INCLUDING_UNICAST(ssub)) { + for (ssub = FIRST_SUBNET; ssub && (ssub != subrec); ssub = NEXT_SUBNET_INCLUDING_UNICAST(ssub)) { for(iwork = ssub->workgrouplist; iwork; iwork = iwork->next) { if(find_server_in_workgroup( iwork, servrec->serv.name) != NULL) { /* -- cgit