From dacb392db6b7585bffe00fae11aab4cc6225c072 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 16 Mar 2011 21:47:10 +0100 Subject: s3: Fix Coverity ID 2234: REVERSE_INULL We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521 --- source3/rpc_server/netlogon/srv_netlog_nt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c index 8e766328f5..bfa3bb25e8 100644 --- a/source3/rpc_server/netlogon/srv_netlog_nt.c +++ b/source3/rpc_server/netlogon/srv_netlog_nt.c @@ -617,10 +617,10 @@ static NTSTATUS samr_find_machine_account(TALLOC_CTX *mem_ctx, } out: - if (b && is_valid_policy_hnd(&domain_handle)) { + if (is_valid_policy_hnd(&domain_handle)) { dcerpc_samr_Close(b, mem_ctx, &domain_handle, &result); } - if (b && is_valid_policy_hnd(&connect_handle)) { + if (is_valid_policy_hnd(&connect_handle)) { dcerpc_samr_Close(b, mem_ctx, &connect_handle, &result); } -- cgit