From dcbfcbbceb87e742b642a9dffee1304dcf0b93bb Mon Sep 17 00:00:00 2001 From: Matthias Dieter Wallnöfer Date: Mon, 18 Oct 2010 21:21:45 +0200 Subject: ldb: always return PROTOCOL_ERROR if an operation is unsupported That's exactly the behaviour of various LDAP servers. --- source4/lib/ldb/ldb_ildap/ldb_ildap.c | 2 +- source4/lib/ldb/ldb_ldap/ldb_ldap.c | 2 +- source4/lib/ldb/ldb_sqlite3/ldb_sqlite3.c | 2 +- source4/lib/ldb/ldb_tdb/ldb_tdb.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/source4/lib/ldb/ldb_ildap/ldb_ildap.c b/source4/lib/ldb/ldb_ildap/ldb_ildap.c index 774336b82e..dab5abf661 100644 --- a/source4/lib/ldb/ldb_ildap/ldb_ildap.c +++ b/source4/lib/ldb/ldb_ildap/ldb_ildap.c @@ -759,7 +759,7 @@ static int ildb_handle_request(struct ldb_module *module, struct ldb_request *re break; default: /* no other op supported */ - ret = LDB_ERR_OPERATIONS_ERROR; + ret = LDB_ERR_PROTOCOL_ERROR; break; } diff --git a/source4/lib/ldb/ldb_ldap/ldb_ldap.c b/source4/lib/ldb/ldb_ldap/ldb_ldap.c index 8383627694..b83ca87c5c 100644 --- a/source4/lib/ldb/ldb_ldap/ldb_ldap.c +++ b/source4/lib/ldb/ldb_ldap/ldb_ldap.c @@ -810,7 +810,7 @@ static int lldb_handle_request(struct ldb_module *module, struct ldb_request *re break; default: /* no other op supported */ - ret = LDB_ERR_OPERATIONS_ERROR; + ret = LDB_ERR_PROTOCOL_ERROR; break; } diff --git a/source4/lib/ldb/ldb_sqlite3/ldb_sqlite3.c b/source4/lib/ldb/ldb_sqlite3/ldb_sqlite3.c index 2225327bbe..3aa6672964 100644 --- a/source4/lib/ldb/ldb_sqlite3/ldb_sqlite3.c +++ b/source4/lib/ldb/ldb_sqlite3/ldb_sqlite3.c @@ -1520,7 +1520,7 @@ static void lsql_callback(struct tevent_context *ev, */ default: /* no other op supported */ - ret = LDB_ERR_UNWILLING_TO_PERFORM; + ret = LDB_ERR_PROTOCOL_ERROR; } if (!ctx->callback_failed) { diff --git a/source4/lib/ldb/ldb_tdb/ldb_tdb.c b/source4/lib/ldb/ldb_tdb/ldb_tdb.c index 435053703e..1637c66734 100644 --- a/source4/lib/ldb/ldb_tdb/ldb_tdb.c +++ b/source4/lib/ldb/ldb_tdb/ldb_tdb.c @@ -1241,7 +1241,7 @@ static void ltdb_callback(struct tevent_context *ev, goto done; default: /* no other op supported */ - ret = LDB_ERR_UNWILLING_TO_PERFORM; + ret = LDB_ERR_PROTOCOL_ERROR; } if (!ctx->request_terminated) { -- cgit