From e6a1027757ef08a5a780175b93ebdb314e91cdba Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 25 Mar 2008 22:35:20 +0100 Subject: Fix a valgrind error In winbind, we're using the info3 struct to send it to the winbind client after netsamlogon_cache_store. Without this info3->base.account_name.string was prematurely freed. (This used to be commit aa4377561b691e2c5108c18aeb34fff39d8775df) --- source3/libsmb/samlogon_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/libsmb/samlogon_cache.c b/source3/libsmb/samlogon_cache.c index 73b570c383..235880910c 100644 --- a/source3/libsmb/samlogon_cache.c +++ b/source3/libsmb/samlogon_cache.c @@ -149,7 +149,7 @@ bool netsamlogon_cache_store(const char *username, struct netr_SamInfo3 *info3) /* so we fill it in since winbindd_getpwnam() makes use of it */ if (!info3->base.account_name.string) { - info3->base.account_name.string = talloc_strdup(mem_ctx, username); + info3->base.account_name.string = talloc_strdup(info3, username); } r.timestamp = t; -- cgit