From ed961d66b242c9f3a32c0b8cbb765771f8c30c00 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Fri, 22 Jun 2007 17:36:10 +0000 Subject: r23590: Fix realloc leak on failure case from Jim Meyering . Jeremy. (This used to be commit d7b39e4534d85c84e8b24668ab7d7a93d5647c23) --- source3/lib/tdb/common/tdb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/source3/lib/tdb/common/tdb.c b/source3/lib/tdb/common/tdb.c index 25103d826e..dce6b58ac8 100644 --- a/source3/lib/tdb/common/tdb.c +++ b/source3/lib/tdb/common/tdb.c @@ -566,8 +566,12 @@ int tdb_append(struct tdb_context *tdb, TDB_DATA key, TDB_DATA new_dbuf) if (dbuf.dptr == NULL) { dbuf.dptr = (unsigned char *)malloc(new_dbuf.dsize); } else { - dbuf.dptr = (unsigned char *)realloc(dbuf.dptr, + unsigned char *new_dptr = (unsigned char *)realloc(dbuf.dptr, dbuf.dsize + new_dbuf.dsize); + if (new_dptr == NULL) { + free(dbuf.dptr); + } + dbuf.dptr = new_dptr; } if (dbuf.dptr == NULL) { -- cgit