From efc7ac209da61d2bd389ccd3b8c8d6d6a6b53989 Mon Sep 17 00:00:00 2001 From: Gerald Carter Date: Sat, 22 Jul 2006 00:53:19 +0000 Subject: r17183: LsaLookupSids() shoudl return the string form of a SID when it cannot be mapped and not the hex of the RID. Who wrote that? (This used to be commit 4e51cf34cf4cbe77957d754952369df3a180f974) --- source3/rpc_server/srv_lsa_nt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/source3/rpc_server/srv_lsa_nt.c b/source3/rpc_server/srv_lsa_nt.c index b4b8876db0..0d8ec75150 100644 --- a/source3/rpc_server/srv_lsa_nt.c +++ b/source3/rpc_server/srv_lsa_nt.c @@ -873,8 +873,9 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p, if (name->type == SID_NAME_UNKNOWN) { name->dom_idx = -1; - name->name = talloc_asprintf(p->mem_ctx, "%8.8x", - name->rid); + /* unknown sids should return the string representation of the SID */ + name->name = talloc_asprintf(p->mem_ctx, "%s", + sid_string_static(sids[i])); if (name->name == NULL) { return NT_STATUS_NO_MEMORY; } -- cgit