From f04579aaf88eede823ef7b9e9035603ae8746f21 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 12 Mar 2006 18:01:36 +0000 Subject: r14249: We've dereferenced the_acl before, no point in checking. Fix Coverity bug # 128. Volker (This used to be commit 84e9e73f3c71a0ccef76d56bc72dcd21160ed286) --- source3/lib/secdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/lib/secdesc.c b/source3/lib/secdesc.c index a443f90dbb..11f963fa0e 100644 --- a/source3/lib/secdesc.c +++ b/source3/lib/secdesc.c @@ -433,7 +433,7 @@ SEC_DESC_BUF *se_create_child_secdesc(TALLOC_CTX *ctx, SEC_DESC *parent_ctr, if (!(new_ace_list = TALLOC_ARRAY(ctx, SEC_ACE, the_acl->num_aces))) return NULL; - for (i = 0; the_acl && i < the_acl->num_aces; i++) { + for (i = 0; i < the_acl->num_aces; i++) { SEC_ACE *ace = &the_acl->ace[i]; SEC_ACE *new_ace = &new_ace_list[new_ace_list_ndx]; uint8 new_flags = 0; -- cgit