From c90b7824a618f878486d8d79a9b06887f05d6873 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Thu, 9 Dec 2010 12:24:48 +1100 Subject: waf: use vscripts for our private libraries too if the library has a vnum, then use it. If it doesn't have a vnum then use the application version for symbol versions --- buildtools/wafsamba/wafsamba.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'buildtools/wafsamba/wafsamba.py') diff --git a/buildtools/wafsamba/wafsamba.py b/buildtools/wafsamba/wafsamba.py index aea9d2bf30..f37f10da16 100644 --- a/buildtools/wafsamba/wafsamba.py +++ b/buildtools/wafsamba/wafsamba.py @@ -195,10 +195,6 @@ def SAMBA_LIBRARY(bld, libname, source, if vnum: Logs.error("vnum is invalid for private libraries") sys.exit(1) - vnum = None - version = "%s_%s" % (Utils.g_module.APPNAME, Utils.g_module.VERSION) - else: - version = "%s_%s" % (Utils.g_module.APPNAME, Utils.g_module.VERSION.split(".")[0]) features = 'cc cshlib symlink_lib install_lib' if target_type == 'PYTHON': @@ -210,10 +206,15 @@ def SAMBA_LIBRARY(bld, libname, source, if abi_directory: features += ' abi_check' - if bld.env.HAVE_LD_VERSION_SCRIPT: - vscript = "%s.vscript" % libname - bld.ABI_VSCRIPT(libname, abi_directory, vnum, vscript) - ldflags.append("-Wl,--version-script=%s/%s" % (bld.path.abspath(bld.env), vscript)) + + if bld.env.HAVE_LD_VERSION_SCRIPT: + vscript = "%s.vscript" % libname + if private_library: + version = "%s_%s" % (Utils.g_module.APPNAME, Utils.g_module.VERSION) + else: + version = "%s_%s" % (libname, vnum) + bld.ABI_VSCRIPT(libname, abi_directory, version, vscript) + ldflags.append("-Wl,--version-script=%s/%s" % (bld.path.abspath(bld.env), vscript)) bld.SET_BUILD_GROUP(group) t = bld( -- cgit