From ccaab14ac423025d1c3188c429832533f19479f1 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Thu, 1 Sep 2011 14:28:10 +1000 Subject: ldb: make the 'spy' code more paranoid the spy code in ldb_tdb was added a while ago to overcome a memory hierarchy problem with async ldb errors. Recently we started to get valgrind errors related to the order of free in the spy code. This patch ensures that we don't try to use a freed spy pointer. This prevents the valgrind errors, although I suspect that the memory hierarchy we have here is more complex than it needs to be Pair-Programmed-With: Andrew Bartlett Autobuild-User: Andrew Tridgell Autobuild-Date: Thu Sep 1 08:54:23 CEST 2011 on sn-devel-104 --- lib/ldb/ldb_tdb/ldb_tdb.h | 8 -------- 1 file changed, 8 deletions(-) (limited to 'lib/ldb/ldb_tdb/ldb_tdb.h') diff --git a/lib/ldb/ldb_tdb/ldb_tdb.h b/lib/ldb/ldb_tdb/ldb_tdb.h index 96ad43fbd6..29856bf827 100644 --- a/lib/ldb/ldb_tdb/ldb_tdb.h +++ b/lib/ldb/ldb_tdb/ldb_tdb.h @@ -33,14 +33,6 @@ struct ltdb_private { bool warn_unindexed; }; -/* - the async local context - holds also internal search state during a full db search -*/ -struct ltdb_req_spy { - struct ltdb_context *ctx; -}; - struct ltdb_context { struct ldb_module *module; struct ldb_request *req; -- cgit