From 6b11c9119fa3e2ea401f86873273533d673e04fa Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Wed, 2 Nov 2011 10:08:32 +1030 Subject: tdb2: don't be fascist when TDB_VERSION1 is specified. We currently insist that a tdb file be a version1 file if tdb_open() is passed the TDB_VERSION1 flag; we fail if it's actually a tdb2. But that makes generic wrappers harder, and is unlikely to be what the user wants: if they do, they can check tdb_get_flags() & TDB_VERSION1 after opening. Signed-off-by: Rusty Russell (Imported from CCAN commit 9691464a16ef22d6acadfef209666381dfe22b2f) Autobuild-User: Rusty Russell Autobuild-Date: Wed Nov 2 08:38:38 CET 2011 on sn-devel-104 --- lib/tdb2/test/api-tdb1-flag-removal.c | 38 +++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 lib/tdb2/test/api-tdb1-flag-removal.c (limited to 'lib/tdb2/test') diff --git a/lib/tdb2/test/api-tdb1-flag-removal.c b/lib/tdb2/test/api-tdb1-flag-removal.c new file mode 100644 index 0000000000..28f24e6388 --- /dev/null +++ b/lib/tdb2/test/api-tdb1-flag-removal.c @@ -0,0 +1,38 @@ +#include +#include +#include +#include +#include +#include + +#include "logging.h" + +int main(int argc, char *argv[]) +{ + unsigned int i; + struct tdb_context *tdb; + int flags[] = { TDB_DEFAULT, TDB_NOMMAP, + TDB_CONVERT, TDB_NOMMAP|TDB_CONVERT }; + + plan_tests(sizeof(flags) / sizeof(flags[0]) * 3 + 1); + for (i = 0; i < sizeof(flags) / sizeof(flags[0]); i++) { + tdb = tdb_open("run-12-store.tdb", flags[i], + O_RDWR|O_CREAT|O_TRUNC, 0600, &tap_log_attr); + if (!ok1(tdb)) + continue; + + tdb_close(tdb); + + tdb = tdb_open("run-12-store.tdb", flags[i] | TDB_VERSION1, + O_RDWR, 0600, &tap_log_attr); + if (!ok1(tdb)) + continue; + /* It's not a version1 */ + ok1(!(tdb_get_flags(tdb) & TDB_VERSION1)); + + tdb_close(tdb); + } + + ok1(tap_log_messages == 0); + return exit_status(); +} -- cgit