From 0080f944b47f3afa676153e5da7093a8667fc005 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@samba.org>
Date: Wed, 30 Mar 2011 06:51:40 +0200
Subject: tdb: Fix Coverity ID 2238: SECURE_CODING

---
 lib/tdb/common/summary.c | 48 ++++++++++++++++++++++++------------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

(limited to 'lib')

diff --git a/lib/tdb/common/summary.c b/lib/tdb/common/summary.c
index da1ec2b739..b222a5993d 100644
--- a/lib/tdb/common/summary.c
+++ b/lib/tdb/common/summary.c
@@ -159,30 +159,30 @@ _PUBLIC_ char *tdb_summary(struct tdb_context *tdb)
 	if (!ret)
 		goto unlock;
 
-	sprintf(ret, SUMMARY_FORMAT,
-		tdb->map_size, keys.total+data.total,
-		keys.num,
-		keys.min, tally_mean(&keys), keys.max,
-		data.min, tally_mean(&data), data.max,
-		extra.min, tally_mean(&extra), extra.max,
-		dead.num,
-		dead.min, tally_mean(&dead), dead.max,
-		freet.num,
-		freet.min, tally_mean(&freet), freet.max,
-		hash.num,
-		hash.min, tally_mean(&hash), hash.max,
-		uncoal.total,
-		uncoal.min, tally_mean(&uncoal), uncoal.max,
-		keys.total * 100.0 / tdb->map_size,
-		data.total * 100.0 / tdb->map_size,
-		extra.total * 100.0 / tdb->map_size,
-		freet.total * 100.0 / tdb->map_size,
-		dead.total * 100.0 / tdb->map_size,
-		(keys.num + freet.num + dead.num)
-		* (sizeof(struct tdb_record) + sizeof(uint32_t))
-		* 100.0 / tdb->map_size,
-		tdb->header.hash_size * sizeof(tdb_off_t)
-		* 100.0 / tdb->map_size);
+	snprintf(ret, len, SUMMARY_FORMAT,
+		 tdb->map_size, keys.total+data.total,
+		 keys.num,
+		 keys.min, tally_mean(&keys), keys.max,
+		 data.min, tally_mean(&data), data.max,
+		 extra.min, tally_mean(&extra), extra.max,
+		 dead.num,
+		 dead.min, tally_mean(&dead), dead.max,
+		 freet.num,
+		 freet.min, tally_mean(&freet), freet.max,
+		 hash.num,
+		 hash.min, tally_mean(&hash), hash.max,
+		 uncoal.total,
+		 uncoal.min, tally_mean(&uncoal), uncoal.max,
+		 keys.total * 100.0 / tdb->map_size,
+		 data.total * 100.0 / tdb->map_size,
+		 extra.total * 100.0 / tdb->map_size,
+		 freet.total * 100.0 / tdb->map_size,
+		 dead.total * 100.0 / tdb->map_size,
+		 (keys.num + freet.num + dead.num)
+		 * (sizeof(struct tdb_record) + sizeof(uint32_t))
+		 * 100.0 / tdb->map_size,
+		 tdb->header.hash_size * sizeof(tdb_off_t)
+		 * 100.0 / tdb->map_size);
 
 unlock:
 	if (locked) {
-- 
cgit