From b0d7a3d123cb96049dc782b317554448acdae1a2 Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra@samba.org>
Date: Wed, 19 May 2010 10:34:44 -0700
Subject: Thanks to Andrew Bartlett's advice, fix the NTLMSSP version problem
 the correct way.

No more magic blobs :-). Use ndr_push_struct_blob() to
push a properly formatted VERSION struct.

Jeremy.
---
 libcli/auth/msrpc_parse.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

(limited to 'libcli/auth/msrpc_parse.c')

diff --git a/libcli/auth/msrpc_parse.c b/libcli/auth/msrpc_parse.c
index 336611d132..7ac6fb57b2 100644
--- a/libcli/auth/msrpc_parse.c
+++ b/libcli/auth/msrpc_parse.c
@@ -174,7 +174,10 @@ bool msrpc_gen(TALLOC_CTX *mem_ctx,
 			break;
 		case 'b':
 			n = pointers[i].length;
-			memcpy(blob->data + head_ofs, pointers[i].data, n);
+			if (pointers[i].data && n) {
+				/* don't follow null pointers... */
+				memcpy(blob->data + head_ofs, pointers[i].data, n);
+			}
 			head_ofs += n;
 			break;
 		case 'C':
-- 
cgit