From 52602e4f5ad0f7c3cdb4a50dfe32d0b8ad49b6e4 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Mon, 28 Mar 2011 13:26:27 -0700 Subject: Fix inspired by work done by David Disseldorp for bug #8040 - smbclient segfaults when a Cyrillic netbios name or workgroup is configured. Change msrpc_gen to return NTSTATUS and ensure everywhere this is used it is correctly checked to return that status. Jeremy. --- libcli/auth/ntlmssp_sign.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'libcli/auth/ntlmssp_sign.c') diff --git a/libcli/auth/ntlmssp_sign.c b/libcli/auth/ntlmssp_sign.c index 0e57c07a8d..42b459c6d4 100644 --- a/libcli/auth/ntlmssp_sign.c +++ b/libcli/auth/ntlmssp_sign.c @@ -130,17 +130,17 @@ static NTSTATUS ntlmssp_make_packet_signature(struct ntlmssp_state *ntlmssp_stat dump_data_pw("ntlmssp v2 sig ", sig->data, sig->length); } else { - bool ok; + NTSTATUS status; uint32_t crc; crc = crc32_calc_buffer(data, length); - ok = msrpc_gen(sig_mem_ctx, + status = msrpc_gen(sig_mem_ctx, sig, "dddd", NTLMSSP_SIGN_VERSION, 0, crc, ntlmssp_state->crypt->ntlm.seq_num); - if (!ok) { - return NT_STATUS_NO_MEMORY; + if (!NT_STATUS_IS_OK(status)) { + return status; } ntlmssp_state->crypt->ntlm.seq_num++; @@ -307,17 +307,17 @@ NTSTATUS ntlmssp_seal_packet(struct ntlmssp_state *ntlmssp_state, sig->data+4, 8); } } else { - bool ok; + NTSTATUS status; uint32_t crc; crc = crc32_calc_buffer(data, length); - ok = msrpc_gen(sig_mem_ctx, + status = msrpc_gen(sig_mem_ctx, sig, "dddd", NTLMSSP_SIGN_VERSION, 0, crc, ntlmssp_state->crypt->ntlm.seq_num); - if (!ok) { - return NT_STATUS_NO_MEMORY; + if (!NT_STATUS_IS_OK(status)) { + return status; } /* -- cgit