From 7c687665eaf16b0c6f83c130f6d9e5459e0b2a32 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 23 Jan 2010 13:48:49 +0100 Subject: libcli/security: Remove a call to strncasecmp --- libcli/security/dom_sid.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'libcli') diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c index 0c8890079a..7cb50c926c 100644 --- a/libcli/security/dom_sid.c +++ b/libcli/security/dom_sid.c @@ -85,16 +85,12 @@ bool dom_sid_equal(const struct dom_sid *sid1, const struct dom_sid *sid2) return dom_sid_compare(sid1, sid2) == 0; } -/* Yes, I did think about multibyte issues here, and for all I can see there's - * none of those for parsing a SID. */ -#undef strncasecmp - bool dom_sid_parse(const char *sidstr, struct dom_sid *ret) { uint_t rev, ia, num_sub_auths, i; char *p; - if (strncasecmp(sidstr, "S-", 2)) { + if ((sidstr[0] != 'S' && sidstr[0] != 's') || sidstr[1] != '-') { return false; } -- cgit