From c60c2c5d94c98e8c2888d912712e0d2155ab7fe7 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Mon, 16 Apr 2012 12:41:30 +0200 Subject: libcli/smb: we should not force a session key for anonymous connections smb2cli_session_set_session_key() should not check for a valid session key, if the connection is a guest or null session. metze --- libcli/smb/smbXcli_base.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'libcli') diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c index 67ab3d0565..9b924ad747 100644 --- a/libcli/smb/smbXcli_base.c +++ b/libcli/smb/smbXcli_base.c @@ -4121,10 +4121,6 @@ NTSTATUS smb2cli_session_set_session_key(struct smbXcli_session *session, return NT_STATUS_INVALID_PARAMETER_MIX; } - if (session->smb2.signing_key.length != 0) { - return NT_STATUS_INVALID_PARAMETER_MIX; - } - no_sign_flags = SMB2_SESSION_FLAG_IS_GUEST | SMB2_SESSION_FLAG_IS_NULL; if (session->smb2.session_flags & no_sign_flags) { @@ -4132,6 +4128,10 @@ NTSTATUS smb2cli_session_set_session_key(struct smbXcli_session *session, return NT_STATUS_OK; } + if (session->smb2.signing_key.length != 0) { + return NT_STATUS_INVALID_PARAMETER_MIX; + } + ZERO_STRUCT(session_key); memcpy(session_key, _session_key.data, MIN(_session_key.length, sizeof(session_key))); -- cgit