From fd5174e88ca1727a91d6dc9bf9bd898ff9087fe8 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 4 Nov 2009 17:42:53 +1100 Subject: lib/util Split data_blob_hex_string() into upper and lower Rather than have a repeat of the bugs we found at the plugfest where hexidecimal strings must be in upper or lower case in particular places, ensure that each caller chooses which case they want. This reverts most of the callers back to upper case, as things were before tridge's patch. The critical call in the extended DN code is of course handled in lower case. Andrew Bartlett --- librpc/ndr/ndr_drsuapi.c | 2 +- librpc/ndr/uuid.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'librpc/ndr') diff --git a/librpc/ndr/ndr_drsuapi.c b/librpc/ndr/ndr_drsuapi.c index bfc3c75b4e..15f2f842bd 100644 --- a/librpc/ndr/ndr_drsuapi.c +++ b/librpc/ndr/ndr_drsuapi.c @@ -91,7 +91,7 @@ _PUBLIC_ void ndr_print_drsuapi_DsReplicaOID(struct ndr_print *ndr, const char * if (r->binary_oid) { char *partial_oid = NULL; DATA_BLOB oid_blob = data_blob_const(r->binary_oid, r->length); - char *hex_str = data_blob_hex_string(ndr, &oid_blob); + char *hex_str = data_blob_hex_string_upper(ndr, &oid_blob); ber_read_partial_OID_String(ndr, oid_blob, (const char **)&partial_oid); ndr->depth++; ndr->print(ndr, "%-25s: 0x%s (%s)", "binary_oid", hex_str, partial_oid); diff --git a/librpc/ndr/uuid.c b/librpc/ndr/uuid.c index 004a8d35cc..df17d7824e 100644 --- a/librpc/ndr/uuid.c +++ b/librpc/ndr/uuid.c @@ -291,7 +291,7 @@ _PUBLIC_ char *GUID_hexstring(TALLOC_CTX *mem_ctx, const struct GUID *guid) return NULL; } - ret = data_blob_hex_string(mem_ctx, &guid_blob); + ret = data_blob_hex_string_upper(mem_ctx, &guid_blob); talloc_free(tmp_mem); return ret; } -- cgit