From 121ad074f96c7cec79a15acb5587d3fd601f3e09 Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 21 Sep 2010 02:17:21 +0200
Subject: pidl/Python: remove todo handling from PythonFunction(), it's done by
 the caller

metze
---
 pidl/lib/Parse/Pidl/Samba4/Python.pm | 21 ++++++---------------
 1 file changed, 6 insertions(+), 15 deletions(-)

(limited to 'pidl/lib/Parse/Pidl/Samba4')

diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index bc56f17fea..e9c9567eb2 100644
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -531,22 +531,13 @@ sub PythonFunction($$$)
 	my $fnname = "py_$fn->{NAME}";
 	my $docstring = $self->DocString($fn, $fn->{NAME});
 
-	my ($insignature, $outsignature);
-	my ($infn, $outfn);
-
-	if (has_property($fn, "todo")) {
-		unless ($docstring) { $docstring = "NULL"; }
-		$infn = "NULL";
-		$outfn = "NULL";
+	my ($infn, $insignature) = $self->PythonFunctionPackIn($fn, $fnname);
+	my ($outfn, $outsignature) = $self->PythonFunctionUnpackOut($fn, $fnname);
+	my $signature = "S.$prettyname($insignature) -> $outsignature";
+	if ($docstring) {
+		$docstring = "\"$signature\\n\\n\"$docstring";
 	} else {
-		($infn, $insignature) = $self->PythonFunctionPackIn($fn, $fnname);
-		($outfn, $outsignature) = $self->PythonFunctionUnpackOut($fn, $fnname);
-		my $signature = "S.$prettyname($insignature) -> $outsignature";
-		if ($docstring) {
-			$docstring = "\"$signature\\n\\n\"$docstring";
-		} else {
-			$docstring = "\"$signature\"";
-		}
+		$docstring = "\"$signature\"";
 	}
 
 	return ($infn, $outfn, $docstring);
-- 
cgit