From db869c5812053f7b71ab92e88e52bed148cad01b Mon Sep 17 00:00:00 2001 From: Amitay Isaacs Date: Fri, 3 Feb 2012 12:04:32 +1100 Subject: selftest: Fix the exit code of make test when run in buildfarm When make test is run in buildfarm environment (RUN_FROM_BUILD_FARM=1), last process in make test pipeline is subunit-filter. This subunit-filter is responsible for converting failure test result to xfail for known failures. While converting failures to xfail, it sets exitcode=1. If this is the last process in the pipeline make test fails, which is the observed behavior in buildfarm. In autobuild, there is additional process in the pipeline format-subunit which processes the output of subunit-filter and correctly terminates with exit code=0. The buildfarm make test failure is fixed by adding extra filter-subunit in the pipeline, as the extra filter-subunit exits correctly with exit code=0. Autobuild-User: Amitay Isaacs Autobuild-Date: Fri Feb 3 07:00:04 CET 2012 on sn-devel-104 --- selftest/wscript | 2 ++ 1 file changed, 2 insertions(+) (limited to 'selftest/wscript') diff --git a/selftest/wscript b/selftest/wscript index 4bd4e665c1..1bfa9f3d47 100644 --- a/selftest/wscript +++ b/selftest/wscript @@ -183,6 +183,8 @@ def cmd_testonly(opt): if (os.environ.get('RUN_FROM_BUILD_FARM') is None and not Options.options.FILTERED_SUBUNIT): cmd += ' | tee ${SELFTEST_PREFIX}/subunit | ${FORMAT_TEST_OUTPUT}' + else: + cmd += ' | ${FILTER_OPTIONS}' runcmd = EXPAND_VARIABLES(opt, cmd) print("test: running %s" % runcmd) -- cgit