From c5d991e5102069ec712fe609c031a10ee8b0f389 Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Sun, 3 Feb 2013 17:06:37 +0100 Subject: Revert "selftest: skip smb2.ioctl tests on ntvfs" This reverts commit cf27c2fbb6e7422cb962f4c63a53515321c65a70. The following concerns were raised with regard to the relocation of tests from selftest/knownfail to selftest/skip. Andrew Bartlett wrote: Unless there is some entirely undesirable side-effect, this patch throws away valuable testing, because it removes the test of the testsuite for failure (ie, does the test work!), and it removes the documentation of the difference between the servers (if someone did add some this to the ntvfs server, it would never be tested). It also removes a test that if this unimplemented functionality is called, that we don't crash and die. Reviewed-by: Andrew Bartlett Autobuild-User(master): David Disseldorp Autobuild-Date(master): Mon Feb 4 15:57:29 CET 2013 on sn-devel-104 --- selftest/knownfail | 2 ++ selftest/skip | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) (limited to 'selftest') diff --git a/selftest/knownfail b/selftest/knownfail index dcd94ecf8e..39485af9d7 100644 --- a/selftest/knownfail +++ b/selftest/knownfail @@ -172,6 +172,8 @@ ^samba3.smb2.durable-v2-open.open-lease ^samba3.smb2.durable-v2-open.persistent-open-lease ^samba3.smb2.durable-v2-open.app-instance +^samba4.smb2.ioctl.req_resume_key\(dc\) # not supported by s4 ntvfs server +^samba4.smb2.ioctl.copy_chunk_\w*\(dc\) # not supported by s4 ntvfs server ^samba3.smb2.dir.one ^samba3.smb2.dir.modify ^samba3.smb2.lease.request diff --git a/selftest/skip b/selftest/skip index d54a5b05f8..5c4930643e 100644 --- a/selftest/skip +++ b/selftest/skip @@ -61,7 +61,6 @@ ^samba4.smb2.dir ^samba4.smb2.session ^samba4.smb2.compound -^samba4.smb2.ioctl # not supported by ntvfs ^samba4.ntvfs.cifs.*.base.charset ^samba4.ntvfs.cifs.*.base.iometer ^samba4.ntvfs.cifs.*.base.casetable -- cgit