From 0bb6053946a1572a3496958e543d5c9ddf74120b Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Mon, 3 Jun 2002 03:07:24 +0000 Subject: put the ifdef for HAVE_VA_COPY in one place rather than in lots of functions (This used to be commit 1cf3228fdc20f0314d1f8e71ad710a5e548b3f72) --- source3/CodingSuggestions | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source3/CodingSuggestions') diff --git a/source3/CodingSuggestions b/source3/CodingSuggestions index 1ff3e01c1c..eda2bee6d0 100644 --- a/source3/CodingSuggestions +++ b/source3/CodingSuggestions @@ -59,8 +59,8 @@ Here are some other suggestions: 6) explicitly add const qualifiers on parm passing in functions where parm is input only (somewhat controversial but const can be #defined away) -7) when passing a va_list as an arg, or assigning one to another, check - for HAVE_VA_COPY, and use it if it exists. +7) when passing a va_list as an arg, or assigning one to another + please use the VA_COPY() macro reason: on some platforms, va_list is a struct that must be initialized in each function...can SEGV if you don't. -- cgit