From 4bb351ac8080c92ff6a84a5cdeca0b158864da1b Mon Sep 17 00:00:00 2001 From: Günther Deschner Date: Fri, 11 Jun 2010 15:05:36 +0200 Subject: s3-auth: Fix valgrind warning (unitialized var) in samu_to_SamInfo3(). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Guenther s3:auth do not fail if there are 0 group sids Signed-off-by: Günther Deschner --- source3/auth/server_info.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'source3/auth') diff --git a/source3/auth/server_info.c b/source3/auth/server_info.c index 1ef272489c..a43c4f931a 100644 --- a/source3/auth/server_info.c +++ b/source3/auth/server_info.c @@ -308,7 +308,7 @@ NTSTATUS samu_to_SamInfo3(TALLOC_CTX *mem_ctx, const struct dom_sid *group_sid; struct dom_sid domain_sid; struct dom_sid *group_sids; - size_t num_group_sids; + size_t num_group_sids = 0; const char *tmp; gid_t *gids; NTSTATUS status; @@ -441,10 +441,12 @@ NTSTATUS samu_to_SamInfo3(TALLOC_CTX *mem_ctx, return status; } - status = group_sids_to_info3(info3, group_sids, num_group_sids); - if (!NT_STATUS_IS_OK(status)) { - TALLOC_FREE(info3); - return status; + if (num_group_sids) { + status = group_sids_to_info3(info3, group_sids, num_group_sids); + if (!NT_STATUS_IS_OK(status)) { + TALLOC_FREE(info3); + return status; + } } /* We don't need sids and gids after the conversion */ -- cgit