From fde330498171c6215a78a72df8be0a20b51cdb32 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 7 Mar 2006 16:28:05 +0000 Subject: r13955: Fix Coverity ID 139. Not a bug in the strictest sense, more a clarification. This whole routine assumes new_gid != NULL anyway, so there's no point in checking. Volker (This used to be commit dfbf09c772b9588271e2d8e053c7494bb087c544) --- source3/groupdb/mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source3/groupdb') diff --git a/source3/groupdb/mapping.c b/source3/groupdb/mapping.c index 5ebc9eb4f5..93e7169204 100644 --- a/source3/groupdb/mapping.c +++ b/source3/groupdb/mapping.c @@ -868,7 +868,7 @@ int smb_create_group(const char *unix_group, gid_t *new_gid) if ( *lp_addgroup_script() ) { pstrcpy(add_script, lp_addgroup_script()); pstring_sub(add_script, "%g", unix_group); - ret = smbrun(add_script, (new_gid!=NULL) ? &fd : NULL); + ret = smbrun(add_script, &fd); DEBUG(ret ? 0 : 3,("smb_create_group: Running the command `%s' gave %d\n",add_script,ret)); if (ret != 0) return ret; -- cgit