From 1c77c7f3d5b6cb29fac4606299c237c0e299f836 Mon Sep 17 00:00:00 2001 From: Derrell Lipman Date: Fri, 16 Jan 2009 16:41:36 -0500 Subject: Treat file names in POSIX-like case-sensitive fashion by default *** THIS COMMIT CAUSES A CHANGE OF DEFAULT BEHAVIOR IN libsmbclient!!! *** - libsmbclient now calls cli_set_case_sensitive() for a new CLI. By default, it requests case-sensitive, but the old behavior of case-insensitive can be requested with smbc_setOptionCaseSensitive(context, False); The change of behavior is considered a bug fix, as it was previously possible to accidentally overwrite a file that had the same case-insensitive name but a different case-sensitive name as a previously-existing file, while creating a new file. Derrell --- source3/include/libsmb_internal.h | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'source3/include/libsmb_internal.h') diff --git a/source3/include/libsmb_internal.h b/source3/include/libsmb_internal.h index b488116939..8b410b4f7f 100644 --- a/source3/include/libsmb_internal.h +++ b/source3/include/libsmb_internal.h @@ -176,6 +176,11 @@ struct SMBC_internal_data { */ smbc_smb_encrypt_level smb_encryption_level; + /* + * Should we request case sensitivity of file names? + */ + bool case_sensitive; + struct smbc_server_cache * server_cache; /* POSIX emulation functions */ -- cgit From c6b4f3526a262b22d5a97a3152f378778a497a26 Mon Sep 17 00:00:00 2001 From: Derrell Lipman Date: Fri, 16 Jan 2009 20:26:46 -0500 Subject: [Bug 6022] smbc_urlencode and smbc_urldecode were not exported - Since the revamp of libsmbclient, there has still been an external declaration for smbc_urlencode and smbc_urldecode in libsmbclient.h, yet those functions were renamed and made private. The two choices were to remove the function names from libsmbclient.h or to make them public again. The reported requested that they be public. This commit makes it so. Derrell --- source3/include/libsmb_internal.h | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'source3/include/libsmb_internal.h') diff --git a/source3/include/libsmb_internal.h b/source3/include/libsmb_internal.h index 8b410b4f7f..67add074bf 100644 --- a/source3/include/libsmb_internal.h +++ b/source3/include/libsmb_internal.h @@ -401,16 +401,6 @@ SMBC_errno(SMBCCTX *context, /* Functions in libsmb_path.c */ -int -SMBC_urldecode(char *dest, - char *src, - size_t max_dest_len); - -int -SMBC_urlencode(char *dest, - char *src, - int max_dest_len); - int SMBC_parse_path(TALLOC_CTX *ctx, SMBCCTX *context, -- cgit