From 4fa555980070d78b39711ef21d77628d26055bc2 Mon Sep 17 00:00:00 2001 From: James Peach Date: Tue, 4 Apr 2006 00:27:50 +0000 Subject: r14898: This change is an attempt to improve the quality of the information that is produced when a process exits abnormally. First, we coalesce the core dumping code so that we greatly improve our odds of being able to produce a core file, even in the case of a memory fault. I've removed duplicates of dump_core() and split it in two to reduce the amount of work needed to actually do the dump. Second, we refactor the exit_server code path to always log an explanation and a stack trace. My goal is to always produce enough log information for us to be able to explain any server exit, though there is a risk that this could produce too much log information on a flaky network. Finally, smbcontrol has gained a smbd fault injection operation to test the changes above. This is only enabled for developer builds. (This used to be commit 56bc02d64498eb3faf89f0c5452b9299daea8e95) --- source3/include/debug.h | 4 ++++ source3/include/includes.h | 6 +++++- source3/include/messages.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) (limited to 'source3/include') diff --git a/source3/include/debug.h b/source3/include/debug.h index 2cf1ceaead..ae9fbeba92 100644 --- a/source3/include/debug.h +++ b/source3/include/debug.h @@ -208,4 +208,8 @@ extern BOOL *DEBUGLEVEL_CLASS_ISSET; DEBUGLEVEL_CLASS[ DBGC_ALL ] >= (level)) ) \ && (dbgtext body) ) +/* Print a separator to the debug log. */ +#define DEBUGSEP(level)\ + DEBUG((level),("===============================================================\n")) + #endif diff --git a/source3/include/includes.h b/source3/include/includes.h index 620af59db7..7702b6645e 100644 --- a/source3/include/includes.h +++ b/source3/include/includes.h @@ -1562,5 +1562,9 @@ LDAP *ldap_open_with_timeout(const char *server, int port, unsigned int to); #endif void smb_panic( const char *why ) NORETURN_ATTRIBUTE ; -void exit_server(const char *reason) NORETURN_ATTRIBUTE ; +void dump_core(void) NORETURN_ATTRIBUTE ; +void exit_server(const char *const reason) NORETURN_ATTRIBUTE ; +void exit_server_cleanly(void) NORETURN_ATTRIBUTE ; +void exit_server_fault(void) NORETURN_ATTRIBUTE ; + #endif /* _INCLUDES_H */ diff --git a/source3/include/messages.h b/source3/include/messages.h index dc4f4ca2c0..6a739c0bcc 100644 --- a/source3/include/messages.h +++ b/source3/include/messages.h @@ -69,6 +69,7 @@ #define MSG_SMB_OPEN_RETRY 3009 #define MSG_SMB_KERNEL_BREAK 3010 #define MSG_SMB_FILE_RENAME 3011 +#define MSG_SMB_INJECT_FAULT 3012 /* winbind messages */ #define MSG_WINBIND_FINISHED 4001 -- cgit