From 603c3e1bcb7b4106afe4aefdfed43e7832ede956 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Thu, 6 Oct 2011 20:34:55 +0200 Subject: s3:dbwrap: convert dbwrap_fetch_int32() to NTSTATUS return code Return the int32 value retrieved from the db by reference. Before this, return value "-1" was used as a error indication, but it could also be a valid value from the database. --- source3/lib/dbwrap/dbwrap.h | 3 ++- source3/lib/dbwrap/dbwrap_util.c | 16 ++++++++++------ 2 files changed, 12 insertions(+), 7 deletions(-) (limited to 'source3/lib/dbwrap') diff --git a/source3/lib/dbwrap/dbwrap.h b/source3/lib/dbwrap/dbwrap.h index 13565f8b33..a549c84d8e 100644 --- a/source3/lib/dbwrap/dbwrap.h +++ b/source3/lib/dbwrap/dbwrap.h @@ -70,7 +70,8 @@ NTSTATUS dbwrap_store_bystring(struct db_context *db, const char *key, NTSTATUS dbwrap_fetch_bystring(struct db_context *db, TALLOC_CTX *mem_ctx, const char *key, TDB_DATA *value); -int32_t dbwrap_fetch_int32(struct db_context *db, const char *keystr); +NTSTATUS dbwrap_fetch_int32(struct db_context *db, const char *keystr, + int32_t *result); int dbwrap_store_int32(struct db_context *db, const char *keystr, int32_t v); bool dbwrap_fetch_uint32(struct db_context *db, const char *keystr, uint32_t *val); diff --git a/source3/lib/dbwrap/dbwrap_util.c b/source3/lib/dbwrap/dbwrap_util.c index 59985479af..5c3940e97b 100644 --- a/source3/lib/dbwrap/dbwrap_util.c +++ b/source3/lib/dbwrap/dbwrap_util.c @@ -26,25 +26,29 @@ #include "dbwrap.h" #include "util_tdb.h" -int32_t dbwrap_fetch_int32(struct db_context *db, const char *keystr) +NTSTATUS dbwrap_fetch_int32(struct db_context *db, const char *keystr, + int32_t *result) { TDB_DATA dbuf; - int32 ret; NTSTATUS status; + if (result == NULL) { + return NT_STATUS_INVALID_PARAMETER; + } + status = dbwrap_fetch_bystring(db, NULL, keystr, &dbuf); if (!NT_STATUS_IS_OK(status)) { - return -1; + return status; } if ((dbuf.dptr == NULL) || (dbuf.dsize != sizeof(int32_t))) { TALLOC_FREE(dbuf.dptr); - return -1; + return NT_STATUS_NOT_FOUND; } - ret = IVAL(dbuf.dptr, 0); + *result = IVAL(dbuf.dptr, 0); TALLOC_FREE(dbuf.dptr); - return ret; + return NT_STATUS_OK; } int dbwrap_store_int32(struct db_context *db, const char *keystr, int32_t v) -- cgit