From 366a2d498d115503067f306a1891ec2063baaeb8 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 16 Jun 2006 12:30:39 +0000 Subject: r16290: Fix Coverity bugs 298 and 298 (This used to be commit b96808bb623c01f2515fdbdede8b4e9edebff23b) --- source3/lib/gencache.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'source3/lib/gencache.c') diff --git a/source3/lib/gencache.c b/source3/lib/gencache.c index defc7ca206..561a019429 100644 --- a/source3/lib/gencache.c +++ b/source3/lib/gencache.c @@ -349,7 +349,7 @@ void gencache_iterate(void (*fn)(const char* key, const char *value, time_t time /* ensure null termination of the key string */ keystr = SMB_STRNDUP(node->node_key.dptr, node->node_key.dsize); if (!keystr) { - return; + break; } /* @@ -367,7 +367,7 @@ void gencache_iterate(void (*fn)(const char* key, const char *value, time_t time if (!entry) { SAFE_FREE(databuf.dptr); SAFE_FREE(keystr); - return; + break; } SAFE_FREE(databuf.dptr); @@ -376,7 +376,7 @@ void gencache_iterate(void (*fn)(const char* key, const char *value, time_t time if (!valstr) { SAFE_FREE(entry); SAFE_FREE(keystr); - return; + break; } asprintf(&fmt, READ_CACHE_DATA_FMT_TEMPLATE, (unsigned int)databuf.dsize - TIMEOUT_LEN); @@ -384,7 +384,7 @@ void gencache_iterate(void (*fn)(const char* key, const char *value, time_t time SAFE_FREE(valstr); SAFE_FREE(entry); SAFE_FREE(keystr); - return; + break; } status = sscanf(entry, fmt, &u, valstr); SAFE_FREE(fmt); -- cgit