From ab37eae79c564ee903ca85c2d997093e17b1de98 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 16 Mar 2011 21:52:20 +0100 Subject: s3: Fix Coverity ID 2231, REVERSE_INULL No point in checking for !ctx after dereferencing it Autobuild-User: Volker Lendecke Autobuild-Date: Wed Mar 16 22:51:52 CET 2011 on sn-devel-104 --- source3/lib/netapi/cm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'source3/lib/netapi/cm.c') diff --git a/source3/lib/netapi/cm.c b/source3/lib/netapi/cm.c index 0e08c6d183..0b8220675d 100644 --- a/source3/lib/netapi/cm.c +++ b/source3/lib/netapi/cm.c @@ -62,8 +62,7 @@ static WERROR libnetapi_open_ipc_connection(struct libnetapi_ctx *ctx, const char *server_name, struct client_ipc_connection **pp) { - struct libnetapi_private_ctx *priv_ctx = - (struct libnetapi_private_ctx *)ctx->private_data; + struct libnetapi_private_ctx *priv_ctx; struct user_auth_info *auth_info = NULL; struct cli_state *cli_ipc = NULL; struct client_ipc_connection *p; @@ -72,6 +71,8 @@ static WERROR libnetapi_open_ipc_connection(struct libnetapi_ctx *ctx, return WERR_INVALID_PARAM; } + priv_ctx = (struct libnetapi_private_ctx *)ctx->private_data; + p = ipc_cm_find(priv_ctx, server_name); if (p) { *pp = p; -- cgit