From 711c18c2301d1bea35cac1144080a94e6b89be27 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Wed, 21 Dec 2011 20:38:32 -0800 Subject: Change the signature of pthreadpool_finished_job() to return 0 on success, errno on fail and return the jobid in a separate variable. I need this fix for my vfs_aio_pthread.c module. Autobuild-User: Jeremy Allison Autobuild-Date: Thu Dec 22 12:12:33 CET 2011 on sn-devel-104 --- source3/lib/pthreadpool/pthreadpool.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'source3/lib/pthreadpool/pthreadpool.c') diff --git a/source3/lib/pthreadpool/pthreadpool.c b/source3/lib/pthreadpool/pthreadpool.c index c916dc0f8d..fffbd050df 100644 --- a/source3/lib/pthreadpool/pthreadpool.c +++ b/source3/lib/pthreadpool/pthreadpool.c @@ -285,16 +285,16 @@ static void pthreadpool_join_children(struct pthreadpool *pool) * Fetch a finished job number from the signal pipe */ -int pthreadpool_finished_job(struct pthreadpool *pool) +int pthreadpool_finished_job(struct pthreadpool *pool, int *jobid) { - int result; + int ret_jobid; ssize_t nread; nread = -1; errno = EINTR; while ((nread == -1) && (errno == EINTR)) { - nread = read(pool->sig_pipe[0], &result, sizeof(int)); + nread = read(pool->sig_pipe[0], &ret_jobid, sizeof(int)); } if (nread == -1) { return errno; @@ -302,7 +302,8 @@ int pthreadpool_finished_job(struct pthreadpool *pool) if (nread != sizeof(int)) { return EINVAL; } - return result; + *jobid = ret_jobid; + return 0; } /* -- cgit