From 03421944b2bd82caf13946b745e4d634f0559f82 Mon Sep 17 00:00:00 2001 From: todd stecher Date: Thu, 12 Feb 2009 00:11:38 -0800 Subject: S3: Stop creating SMBD cores when failing to create a pipe. This was uncovered when the MAX FD limit was hit, causing an instant core and invoking error reporting. This fix causes SMBD to exit, but without building a core. --- source3/lib/select.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'source3/lib') diff --git a/source3/lib/select.c b/source3/lib/select.c index 14e59257ba..a58530af8d 100644 --- a/source3/lib/select.c +++ b/source3/lib/select.c @@ -59,7 +59,17 @@ int sys_select(int maxfd, fd_set *readfds, fd_set *writefds, fd_set *errorfds, s if (initialised != sys_getpid()) { if (pipe(select_pipe) == -1) - smb_panic("Could not create select pipe"); + { + DEBUG(0, ("sys_select: pipe failed (%s)\n", + strerror(errno))); + if (readfds != NULL) + FD_ZERO(readfds); + if (writefds != NULL) + FD_ZERO(writefds); + if (errorfds != NULL) + FD_ZERO(errorfds); + return -1; + } /* * These next two lines seem to fix a bug with the Linux -- cgit