From 1abdd9b2bb09d072496db5207814aefefe403f60 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Wed, 6 Jul 2011 16:40:21 +0200 Subject: s3:dbwrap: move db_open() to a file dbwrap_open.c of its own. Also start new folder lib/dbwrap/ where dbwrap_open.c is stored and make the fallbacke implementation functoins non-static and create a dbwrap_private.h header file that contains their prototypes. --- source3/lib/conn_tdb.c | 1 + source3/lib/dbwrap.c | 81 ++++---------------------------- source3/lib/dbwrap/dbwrap_open.c | 92 +++++++++++++++++++++++++++++++++++++ source3/lib/dbwrap/dbwrap_open.h | 37 +++++++++++++++ source3/lib/dbwrap/dbwrap_private.h | 38 +++++++++++++++ source3/lib/g_lock.c | 1 + source3/lib/serverid.c | 1 + source3/lib/sessionid_tdb.c | 1 + source3/lib/sharesec.c | 1 + 9 files changed, 182 insertions(+), 71 deletions(-) create mode 100644 source3/lib/dbwrap/dbwrap_open.c create mode 100644 source3/lib/dbwrap/dbwrap_open.h create mode 100644 source3/lib/dbwrap/dbwrap_private.h (limited to 'source3/lib') diff --git a/source3/lib/conn_tdb.c b/source3/lib/conn_tdb.c index 50f0d9fa1b..669ddb2a3a 100644 --- a/source3/lib/conn_tdb.c +++ b/source3/lib/conn_tdb.c @@ -21,6 +21,7 @@ #include "system/filesys.h" #include "smbd/globals.h" #include "dbwrap.h" +#include "dbwrap/dbwrap_open.h" static struct db_context *connections_db_ctx(bool rw) { diff --git a/source3/lib/dbwrap.c b/source3/lib/dbwrap.c index 83fc40efac..0774974ced 100644 --- a/source3/lib/dbwrap.c +++ b/source3/lib/dbwrap.c @@ -21,16 +21,19 @@ #include "includes.h" #include "dbwrap.h" +#include "dbwrap/dbwrap_private.h" #include "util_tdb.h" #ifdef CLUSTER_SUPPORT #include "ctdb_private.h" #endif + + /* * Fall back using fetch_locked if no genuine fetch operation is provided */ -static int dbwrap_fallback_fetch(struct db_context *db, TALLOC_CTX *mem_ctx, - TDB_DATA key, TDB_DATA *data) +int dbwrap_fallback_fetch(struct db_context *db, TALLOC_CTX *mem_ctx, + TDB_DATA key, TDB_DATA *data) { struct db_record *rec; @@ -48,11 +51,11 @@ static int dbwrap_fallback_fetch(struct db_context *db, TALLOC_CTX *mem_ctx, * Fall back using fetch if no genuine parse operation is provided */ -static int dbwrap_fallback_parse_record(struct db_context *db, TDB_DATA key, - int (*parser)(TDB_DATA key, - TDB_DATA data, - void *private_data), - void *private_data) +int dbwrap_fallback_parse_record(struct db_context *db, TDB_DATA key, + int (*parser)(TDB_DATA key, + TDB_DATA data, + void *private_data), + void *private_data) { TDB_DATA data; int res; @@ -93,67 +96,3 @@ bool db_is_local(const char *name) #endif return true; } - -/** - * open a database - */ -struct db_context *db_open(TALLOC_CTX *mem_ctx, - const char *name, - int hash_size, int tdb_flags, - int open_flags, mode_t mode) -{ - struct db_context *result = NULL; -#ifdef CLUSTER_SUPPORT - const char *sockname = lp_ctdbd_socket(); - - if(!sockname || !*sockname) { - sockname = CTDB_PATH; - } - - if (lp_clustering()) { - const char *partname; - - if (!socket_exist(sockname)) { - DEBUG(1, ("ctdb socket does not exist - is ctdb not " - "running?\n")); - return NULL; - } - - /* ctdb only wants the file part of the name */ - partname = strrchr(name, '/'); - if (partname) { - partname++; - } else { - partname = name; - } - /* allow ctdb for individual databases to be disabled */ - if (lp_parm_bool(-1, "ctdb", partname, True)) { - result = db_open_ctdb(mem_ctx, partname, hash_size, - tdb_flags, open_flags, mode); - if (result == NULL) { - DEBUG(0,("failed to attach to ctdb %s\n", - partname)); - if (errno == 0) { - errno = EIO; - } - return NULL; - } - } - } - -#endif - - if (result == NULL) { - result = db_open_tdb(mem_ctx, name, hash_size, - tdb_flags, open_flags, mode); - } - - if ((result != NULL) && (result->fetch == NULL)) { - result->fetch = dbwrap_fallback_fetch; - } - if ((result != NULL) && (result->parse_record == NULL)) { - result->parse_record = dbwrap_fallback_parse_record; - } - - return result; -} diff --git a/source3/lib/dbwrap/dbwrap_open.c b/source3/lib/dbwrap/dbwrap_open.c new file mode 100644 index 0000000000..d6b2f30ef6 --- /dev/null +++ b/source3/lib/dbwrap/dbwrap_open.c @@ -0,0 +1,92 @@ +/* + Unix SMB/CIFS implementation. + Database interface wrapper + + Copyright (C) Volker Lendecke 2005-2007 + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . +*/ + +#include "includes.h" +#include "dbwrap.h" +#include "dbwrap/dbwrap_private.h" +#include "dbwrap/dbwrap_open.h" +#include "util_tdb.h" +#ifdef CLUSTER_SUPPORT +#include "ctdb_private.h" +#endif + +/** + * open a database + */ +struct db_context *db_open(TALLOC_CTX *mem_ctx, + const char *name, + int hash_size, int tdb_flags, + int open_flags, mode_t mode) +{ + struct db_context *result = NULL; +#ifdef CLUSTER_SUPPORT + const char *sockname = lp_ctdbd_socket(); + + if(!sockname || !*sockname) { + sockname = CTDB_PATH; + } + + if (lp_clustering()) { + const char *partname; + + if (!socket_exist(sockname)) { + DEBUG(1, ("ctdb socket does not exist - is ctdb not " + "running?\n")); + return NULL; + } + + /* ctdb only wants the file part of the name */ + partname = strrchr(name, '/'); + if (partname) { + partname++; + } else { + partname = name; + } + /* allow ctdb for individual databases to be disabled */ + if (lp_parm_bool(-1, "ctdb", partname, True)) { + result = db_open_ctdb(mem_ctx, partname, hash_size, + tdb_flags, open_flags, mode); + if (result == NULL) { + DEBUG(0,("failed to attach to ctdb %s\n", + partname)); + if (errno == 0) { + errno = EIO; + } + return NULL; + } + } + } + +#endif + + if (result == NULL) { + result = db_open_tdb(mem_ctx, name, hash_size, + tdb_flags, open_flags, mode); + } + + if ((result != NULL) && (result->fetch == NULL)) { + result->fetch = dbwrap_fallback_fetch; + } + if ((result != NULL) && (result->parse_record == NULL)) { + result->parse_record = dbwrap_fallback_parse_record; + } + + return result; +} diff --git a/source3/lib/dbwrap/dbwrap_open.h b/source3/lib/dbwrap/dbwrap_open.h new file mode 100644 index 0000000000..153e91ad5d --- /dev/null +++ b/source3/lib/dbwrap/dbwrap_open.h @@ -0,0 +1,37 @@ +/* + Unix SMB/CIFS implementation. + Database interface wrapper around tdb + + Copyright (C) Volker Lendecke 2005-2007 + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . +*/ + +#ifndef __DBWRAP_OPEN_H__ +#define __DBWRAP_OPEN_H__ + +struct db_context; + +/** + * Convenience function that will determine whether to + * open a tdb database via the tdb backend or via the ctdb + * backend, based on lp_clustering() and a db-specific + * settings. + */ +struct db_context *db_open(TALLOC_CTX *mem_ctx, + const char *name, + int hash_size, int tdb_flags, + int open_flags, mode_t mode); + +#endif /* __DBWRAP_OPEN_H__ */ diff --git a/source3/lib/dbwrap/dbwrap_private.h b/source3/lib/dbwrap/dbwrap_private.h new file mode 100644 index 0000000000..c8f3a1062f --- /dev/null +++ b/source3/lib/dbwrap/dbwrap_private.h @@ -0,0 +1,38 @@ +/* + Unix SMB/CIFS implementation. + Database interface wrapper around tdb - private header + + Copyright (C) Volker Lendecke 2005-2007 + Copyright (C) Gregor Beck 2011 + Copyright (C) Michael Adam 2011 + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . +*/ + +#ifndef __DBWRAP_PRIVATE_H__ +#define __DBWRAP_PRIVATE_H__ + + +int dbwrap_fallback_fetch(struct db_context *db, TALLOC_CTX *mem_ctx, + TDB_DATA key, TDB_DATA *data); + + +int dbwrap_fallback_parse_record(struct db_context *db, TDB_DATA key, + int (*parser)(TDB_DATA key, + TDB_DATA data, + void *private_data), + void *private_data); + +#endif /* __DBWRAP_PRIVATE_H__ */ + diff --git a/source3/lib/g_lock.c b/source3/lib/g_lock.c index c4ac8e372b..3a983d5fb7 100644 --- a/source3/lib/g_lock.c +++ b/source3/lib/g_lock.c @@ -20,6 +20,7 @@ #include "includes.h" #include "system/filesys.h" #include "dbwrap.h" +#include "dbwrap/dbwrap_open.h" #include "g_lock.h" #include "util_tdb.h" #include "ctdbd_conn.h" diff --git a/source3/lib/serverid.c b/source3/lib/serverid.c index 1a1141265a..f2ba07ab34 100644 --- a/source3/lib/serverid.c +++ b/source3/lib/serverid.c @@ -22,6 +22,7 @@ #include "serverid.h" #include "util_tdb.h" #include "dbwrap.h" +#include "dbwrap/dbwrap_open.h" #include "lib/util/tdb_wrap.h" struct serverid_key { diff --git a/source3/lib/sessionid_tdb.c b/source3/lib/sessionid_tdb.c index de3ccab26a..dc3f61c33b 100644 --- a/source3/lib/sessionid_tdb.c +++ b/source3/lib/sessionid_tdb.c @@ -20,6 +20,7 @@ #include "includes.h" #include "system/filesys.h" #include "dbwrap.h" +#include "dbwrap/dbwrap_open.h" #include "session.h" #include "util_tdb.h" diff --git a/source3/lib/sharesec.c b/source3/lib/sharesec.c index 11ccb42300..fa67567537 100644 --- a/source3/lib/sharesec.c +++ b/source3/lib/sharesec.c @@ -22,6 +22,7 @@ #include "../libcli/security/security.h" #include "../librpc/gen_ndr/ndr_security.h" #include "dbwrap.h" +#include "dbwrap/dbwrap_open.h" #include "util_tdb.h" /******************************************************************* -- cgit