From 1f2a901d788f73d7f411129b59a261a5512b6b7d Mon Sep 17 00:00:00 2001 From: Martin Pool Date: Thu, 13 Feb 2003 04:46:55 +0000 Subject: Add FIXME about checking exit code for popen'd commands. Fix typo. (This used to be commit 2b5664823e05e328c86051fb607182ad20d786d4) --- source3/lib/util_file.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'source3/lib') diff --git a/source3/lib/util_file.c b/source3/lib/util_file.c index 611e0e40be..4babab8931 100644 --- a/source3/lib/util_file.c +++ b/source3/lib/util_file.c @@ -362,7 +362,7 @@ char *file_pload(char *syscmd, size_t *size) while ((n = read(fd, buf, sizeof(buf))) > 0) { tp = Realloc(p, total + n + 1); if (!tp) { - DEBUG(0,("file_pload: failed to exand buffer!\n")); + DEBUG(0,("file_pload: failed to expand buffer!\n")); close(fd); SAFE_FREE(p); return NULL; @@ -372,6 +372,9 @@ char *file_pload(char *syscmd, size_t *size) } if (p) p[total] = 0; + /* FIXME: Perhaps ought to check that the command completed + * successfully (returned 0); if not the data may be + * truncated. */ sys_pclose(fd); if (size) *size = total; -- cgit