From 43ad653211114ddd7c85e7d9dfe13e957a97c71d Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Wed, 8 Mar 2006 06:36:40 +0000 Subject: r14020: Coverity bug CID #66. Missing free on error exit. Jeremy. (This used to be commit b9980bddf5ee74b2887196d6d1a0cf393720ba3a) --- source3/lib/xfile.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'source3/lib') diff --git a/source3/lib/xfile.c b/source3/lib/xfile.c index 5bb93179af..71f8bdbcbb 100644 --- a/source3/lib/xfile.c +++ b/source3/lib/xfile.c @@ -96,13 +96,16 @@ XFILE *x_fopen(const char *fname, int flags, mode_t mode) XFILE *ret; ret = SMB_MALLOC_P(XFILE); - if (!ret) return NULL; + if (!ret) { + return NULL; + } memset(ret, 0, sizeof(XFILE)); if ((flags & O_ACCMODE) == O_RDWR) { /* we don't support RDWR in XFILE - use file descriptors instead */ + SAFE_FREE(ret); errno = EINVAL; return NULL; } -- cgit