From d6a5476ee7af464a381bbeeec576ee58f3650a43 Mon Sep 17 00:00:00 2001 From: Jelmer Vernooij Date: Thu, 23 Oct 2008 19:53:15 +0200 Subject: Use sockaddr_storage only where we rely on the size, use sockaddr otherwise (to clarify we can also pass in structs smaller than sockaddr_storage, such as sockaddr_in). --- source3/libads/kerberos.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'source3/libads/kerberos.c') diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c index 501ef010fd..4658f66cfd 100644 --- a/source3/libads/kerberos.c +++ b/source3/libads/kerberos.c @@ -772,7 +772,8 @@ static char *get_kdc_ip_string(char *mem_ctx, get_kdc_list(realm, sitename, &ip_srv_site, &count_site); for (i = 0; i < count_site; i++) { - if (addr_equal(&ip_srv_site[i].ss, pss)) { + if (addr_equal((struct sockaddr *)&ip_srv_site[i].ss, + (struct sockaddr *)pss)) { continue; } /* Append to the string - inefficient @@ -794,14 +795,14 @@ static char *get_kdc_ip_string(char *mem_ctx, for (i = 0; i < count_nonsite; i++) { int j; - if (addr_equal(&ip_srv_nonsite[i].ss, pss)) { + if (addr_equal((struct sockaddr *)&ip_srv_nonsite[i].ss, (struct sockaddr *)pss)) { continue; } /* Ensure this isn't an IP already seen (YUK! this is n*n....) */ for (j = 0; j < count_site; j++) { - if (addr_equal(&ip_srv_nonsite[i].ss, - &ip_srv_site[j].ss)) { + if (addr_equal((struct sockaddr *)&ip_srv_nonsite[i].ss, + (struct sockaddr *)&ip_srv_site[j].ss)) { break; } /* As the lists are sorted we can break early if nonsite > site. */ -- cgit