From 25fc58afcd6051cd387a7114afadab2a85b98cfb Mon Sep 17 00:00:00 2001 From: Günther Deschner Date: Tue, 10 Feb 2009 10:45:55 +0100 Subject: s3-spoolss: fix memleak in get_remote_printer_publishing_data(). Guenther --- source3/libads/ldap_printer.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'source3/libads') diff --git a/source3/libads/ldap_printer.c b/source3/libads/ldap_printer.c index c9c43f0e10..1bcb86e996 100644 --- a/source3/libads/ldap_printer.c +++ b/source3/libads/ldap_printer.c @@ -327,11 +327,14 @@ WERROR get_remote_printer_publishing_data(struct rpc_pipe_client *cli, if (!W_ERROR_IS_OK(result)) { DEBUG(3, ("Unable to open printer %s, error is %s.\n", printername, win_errstr(result))); + SAFE_FREE(printername); return result; } - if ( !(dsdriver_ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) ) + if ( !(dsdriver_ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) ) { + SAFE_FREE(printername); return WERR_NOMEM; + } result = rpccli_spoolss_enumprinterdataex(cli, mem_ctx, &pol, SPOOL_DSDRIVER_KEY, dsdriver_ctr); @@ -347,8 +350,10 @@ WERROR get_remote_printer_publishing_data(struct rpc_pipe_client *cli, } } - if ( !(dsspooler_ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) ) + if ( !(dsspooler_ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) ) { + SAFE_FREE(printername); return WERR_NOMEM; + } result = rpccli_spoolss_enumprinterdataex(cli, mem_ctx, &pol, SPOOL_DSSPOOLER_KEY, dsspooler_ctr); @@ -369,6 +374,7 @@ WERROR get_remote_printer_publishing_data(struct rpc_pipe_client *cli, TALLOC_FREE( dsspooler_ctr ); rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL); + SAFE_FREE(printername); return result; } -- cgit